Skip to content

Commit

Permalink
rolled in review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
scmacdon committed Nov 25, 2024
1 parent e9f6030 commit 38da03e
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ public static void main(String[]args) throws ParseException {
bucketName - The ARN of the S3 bucket where the job report will be stored.
roleArn - The ARN of the IAM role that will be used to perform the governance retention operation.
accountId - Your AWS account Id.
manifestObjectVersionId = A unique value that is used as the `eTag` property of the `JobManifestLocation` object.
""";

if (args.length != 4) {
Expand All @@ -45,13 +46,13 @@ public static void main(String[]args) throws ParseException {
String jobReportBucketArn = args[1];
String roleArn = args[2];
String accountId = args[3];
String manifestObjectVersionId = args[4];

S3ControlClient s3ControlClient = S3ControlClient.create();
createGovernanceRetentionJob(s3ControlClient, manifestObjectArn, jobReportBucketArn, roleArn, accountId);
createGovernanceRetentionJob(s3ControlClient, manifestObjectArn, jobReportBucketArn, roleArn, accountId, manifestObjectVersionId);
}

public static String createGovernanceRetentionJob(final S3ControlClient s3ControlClient, String manifestObjectArn, String jobReportBucketArn, String roleArn, String accountId) throws ParseException {
final String manifestObjectVersionId = "15ad5ba069e6bbc465c77bf83d541385";
public static String createGovernanceRetentionJob(final S3ControlClient s3ControlClient, String manifestObjectArn, String jobReportBucketArn, String roleArn, String accountId, String manifestObjectVersionId) throws ParseException {
final JobManifestLocation manifestLocation = JobManifestLocation.builder()
.objectArn(manifestObjectArn)
.eTag(manifestObjectVersionId)
Expand Down

0 comments on commit 38da03e

Please sign in to comment.