Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Liz Kellebrew-Davies <[email protected]>
  • Loading branch information
Laren-AWS and lkdavies authored Sep 18, 2023
1 parent 7ed63ee commit f5f6b21
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 10 deletions.
7 changes: 4 additions & 3 deletions .doc_gen/metadata/ec2_metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1737,7 +1737,8 @@ ec2_ReplaceIamInstanceProfileAssociation:
github: python/example_code/ec2
sdkguide:
excerpts:
- description: This example replace the instance profile of a running instance,
- description: This example replaces the instance profile of a running instance,

reboots the instance, and sends a command to the instance after it starts.
snippet_tags:
- python.cross_service.resilient_service.AutoScaler.decl
Expand All @@ -1757,8 +1758,8 @@ ec2_CreateLaunchTemplate:
sdkguide:
excerpts:
- description: This example creates a launch template that includes an instance profile
that grants specific permissions to the instance, and a user data Bash script that is
run on the instance after it starts.
that grants specific permissions to the instance, and a user data Bash script that runs on the instance after it starts.

snippet_tags:
- python.cross_service.resilient_service.AutoScaler.decl
- python.cross_service.resilient_service.ec2.CreateLaunchTemplate
Expand Down
8 changes: 4 additions & 4 deletions python/example_code/auto-scaling/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Shows how to use the AWS SDK for Python (Boto3) to work with Amazon EC2 Auto Sca

## ⚠ Important

* Running this code might result in charges to your AWS account. See [AWS Pricing](https://aws.amazon.com/pricing/?aws-products-pricing.sort-by=item.additionalFields.productNameLowercase&aws-products-pricing.sort-order=asc&awsf.Free%20Tier%20Type=*all&awsf.tech-category=*all) and [Free Tier](https://aws.amazon.com/free/?all-free-tier.sort-by=item.additionalFields.SortRank&all-free-tier.sort-order=asc&awsf.Free%20Tier%20Types=*all&awsf.Free%20Tier%20Categories=*all) for more details.
* Running this code might result in charges to your AWS account. For more details, see [AWS Pricing](https://aws.amazon.com/pricing/?aws-products-pricing.sort-by=item.additionalFields.productNameLowercase&aws-products-pricing.sort-order=asc&awsf.Free%20Tier%20Type=*all&awsf.tech-category=*all) and [Free Tier](https://aws.amazon.com/free/?all-free-tier.sort-by=item.additionalFields.SortRank&all-free-tier.sort-order=asc&awsf.Free%20Tier%20Types=*all&awsf.Free%20Tier%20Categories=*all).
* Running the tests might result in charges to your AWS account.
* We recommend that you grant your code least privilege. At most, grant only the minimum permissions required to perform the task. For more information, see [Grant least privilege](https://docs.aws.amazon.com/IAM/latest/UserGuide/best-practices.html#grant-least-privilege).
* This code is not tested in every AWS Region. For more information, see [AWS Regional Services](https://aws.amazon.com/about-aws/global-infrastructure/regional-product-services).
Expand All @@ -38,7 +38,7 @@ python -m pip install -r requirements.txt

### Get started

* [Hello Auto Scaling](hello.py#L4) (`DescribeAutoScalingGroups`)
* [Hello Amazon EC2 Auto Scaling](hello.py#L4) (`DescribeAutoScalingGroups`)

### Single actions

Expand Down Expand Up @@ -72,9 +72,9 @@ functions within the same service.
<!--custom.instructions.start-->
<!--custom.instructions.end-->

#### Hello Auto Scaling
#### Hello Amazon EC2 Auto Scaling

This example shows you how to get started using Auto Scaling.
This example shows you how to get started using Amazon EC2 Auto Scaling.

```
python hello.py
Expand Down
2 changes: 1 addition & 1 deletion python/example_code/ec2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Shows how to use the AWS SDK for Python (Boto3) to work with Amazon Elastic Comp

## ⚠ Important

* Running this code might result in charges to your AWS account. See [AWS Pricing](https://aws.amazon.com/pricing/?aws-products-pricing.sort-by=item.additionalFields.productNameLowercase&aws-products-pricing.sort-order=asc&awsf.Free%20Tier%20Type=*all&awsf.tech-category=*all) and [Free Tier](https://aws.amazon.com/free/?all-free-tier.sort-by=item.additionalFields.SortRank&all-free-tier.sort-order=asc&awsf.Free%20Tier%20Types=*all&awsf.Free%20Tier%20Categories=*all) for more details.
* Running this code might result in charges to your AWS account. For more details, see [AWS Pricing](https://aws.amazon.com/pricing/?aws-products-pricing.sort-by=item.additionalFields.productNameLowercase&aws-products-pricing.sort-order=asc&awsf.Free%20Tier%20Type=*all&awsf.tech-category=*all) and [Free Tier](https://aws.amazon.com/free/?all-free-tier.sort-by=item.additionalFields.SortRank&all-free-tier.sort-order=asc&awsf.Free%20Tier%20Types=*all&awsf.Free%20Tier%20Categories=*all).
* Running the tests might result in charges to your AWS account.
* We recommend that you grant your code least privilege. At most, grant only the minimum permissions required to perform the task. For more information, see [Grant least privilege](https://docs.aws.amazon.com/IAM/latest/UserGuide/best-practices.html#grant-least-privilege).
* This code is not tested in every AWS Region. For more information, see [AWS Regional Services](https://aws.amazon.com/about-aws/global-infrastructure/regional-product-services).
Expand Down
2 changes: 1 addition & 1 deletion python/example_code/elastic-load-balancing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ scenario.

## ⚠ Important

* Running this code might result in charges to your AWS account. See [AWS Pricing](https://aws.amazon.com/pricing/?aws-products-pricing.sort-by=item.additionalFields.productNameLowercase&aws-products-pricing.sort-order=asc&awsf.Free%20Tier%20Type=*all&awsf.tech-category=*all) and [Free Tier](https://aws.amazon.com/free/?all-free-tier.sort-by=item.additionalFields.SortRank&all-free-tier.sort-order=asc&awsf.Free%20Tier%20Types=*all&awsf.Free%20Tier%20Categories=*all) for more details.
* Running this code might result in charges to your AWS account. For more details, see [AWS Pricing](https://aws.amazon.com/pricing/?aws-products-pricing.sort-by=item.additionalFields.productNameLowercase&aws-products-pricing.sort-order=asc&awsf.Free%20Tier%20Type=*all&awsf.tech-category=*all) and [Free Tier](https://aws.amazon.com/free/?all-free-tier.sort-by=item.additionalFields.SortRank&all-free-tier.sort-order=asc&awsf.Free%20Tier%20Types=*all&awsf.Free%20Tier%20Categories=*all).
* Running the tests might result in charges to your AWS account.
* We recommend that you grant your code least privilege. At most, grant only the minimum permissions required to perform the task. For more information, see [Grant least privilege](https://docs.aws.amazon.com/IAM/latest/UserGuide/best-practices.html#grant-least-privilege).
* This code is not tested in every AWS Region. For more information, see [AWS Regional Services](https://aws.amazon.com/about-aws/global-infrastructure/regional-product-services).
Expand Down
2 changes: 1 addition & 1 deletion python/example_code/iam/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Shows how to use the AWS SDK for Python (Boto3) to work with AWS Identity and Ac

## ⚠ Important

* Running this code might result in charges to your AWS account. See [AWS Pricing](https://aws.amazon.com/pricing/?aws-products-pricing.sort-by=item.additionalFields.productNameLowercase&aws-products-pricing.sort-order=asc&awsf.Free%20Tier%20Type=*all&awsf.tech-category=*all) and [Free Tier](https://aws.amazon.com/free/?all-free-tier.sort-by=item.additionalFields.SortRank&all-free-tier.sort-order=asc&awsf.Free%20Tier%20Types=*all&awsf.Free%20Tier%20Categories=*all) for more details.
* Running this code might result in charges to your AWS account. For more details, see [AWS Pricing](https://aws.amazon.com/pricing/?aws-products-pricing.sort-by=item.additionalFields.productNameLowercase&aws-products-pricing.sort-order=asc&awsf.Free%20Tier%20Type=*all&awsf.tech-category=*all) and [Free Tier](https://aws.amazon.com/free/?all-free-tier.sort-by=item.additionalFields.SortRank&all-free-tier.sort-order=asc&awsf.Free%20Tier%20Types=*all&awsf.Free%20Tier%20Categories=*all).
* Running the tests might result in charges to your AWS account.
* We recommend that you grant your code least privilege. At most, grant only the minimum permissions required to perform the task. For more information, see [Grant least privilege](https://docs.aws.amazon.com/IAM/latest/UserGuide/best-practices.html#grant-least-privilege).
* This code is not tested in every AWS Region. For more information, see [AWS Regional Services](https://aws.amazon.com/about-aws/global-infrastructure/regional-product-services).
Expand Down

0 comments on commit f5f6b21

Please sign in to comment.