-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript (v3): Task - Cleanup nodegetstarted #5433
Merged
meyertst-aws
merged 3 commits into
awsdocs:main
from
cpyle0819:corepyle/cleanup-nodegetstarted
Oct 2, 2023
Merged
JavaScript (v3): Task - Cleanup nodegetstarted #5433
meyertst-aws
merged 3 commits into
awsdocs:main
from
cpyle0819:corepyle/cleanup-nodegetstarted
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpyle0819
added
On Call Review needed
This work needs an on-call review
Text Review needed
This work needs editorial (text) review
Task
labels
Sep 27, 2023
github-actions
bot
added
the
Javascript-v3
This issue relates to the AWS SDK for Javascript V3
label
Sep 27, 2023
cpyle0819
force-pushed
the
corepyle/cleanup-nodegetstarted
branch
from
September 27, 2023 20:24
e160378
to
7f5f15d
Compare
lkdavies
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial comments
lkdavies
added
Text Review complete
Text review complete
and removed
Text Review needed
This work needs editorial (text) review
labels
Sep 27, 2023
cpyle0819
requested review from
a team and
ford-at-aws
and removed request for
beqqrry-aws and
a team
September 28, 2023 13:08
meyertst-aws
approved these changes
Oct 2, 2023
meyertst-aws
added
On Call Review complete
On call review complete
and removed
On Call Review needed
This work needs an on-call review
labels
Oct 2, 2023
Co-authored-by: Liz Kellebrew-Davies <[email protected]>
Co-authored-by: Liz Kellebrew-Davies <[email protected]>
meyertst-aws
force-pushed
the
corepyle/cleanup-nodegetstarted
branch
from
October 2, 2023 13:12
f9bba41
to
7df20fb
Compare
ford-at-aws
pushed a commit
that referenced
this pull request
Dec 15, 2023
* JavaScript (v3): Task - Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Javascript-v3
This issue relates to the AWS SDK for Javascript V3
On Call Review complete
On call review complete
Text Review complete
Text review complete
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does some supporting code changes for the JS guide.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.