Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript (v3): Task - Cleanup nodegetstarted #5433

Merged

Conversation

cpyle0819
Copy link
Contributor

This pull request does some supporting code changes for the JS guide.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 added On Call Review needed This work needs an on-call review Text Review needed This work needs editorial (text) review Task labels Sep 27, 2023
@cpyle0819 cpyle0819 requested a review from a team September 27, 2023 20:21
@cpyle0819 cpyle0819 self-assigned this Sep 27, 2023
@cpyle0819 cpyle0819 requested review from beqqrry-aws and removed request for a team September 27, 2023 20:21
@github-actions github-actions bot added the Javascript-v3 This issue relates to the AWS SDK for Javascript V3 label Sep 27, 2023
@cpyle0819 cpyle0819 force-pushed the corepyle/cleanup-nodegetstarted branch from e160378 to 7f5f15d Compare September 27, 2023 20:24
Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

javascriptv3/example_code/nodegetstarted/README.md Outdated Show resolved Hide resolved
javascriptv3/example_code/nodegetstarted/README.md Outdated Show resolved Hide resolved
javascriptv3/example_code/nodegetstarted/README.md Outdated Show resolved Hide resolved
javascriptv3/example_code/nodegetstarted/README.md Outdated Show resolved Hide resolved
javascriptv3/example_code/nodegetstarted/README.md Outdated Show resolved Hide resolved
javascriptv3/example_code/nodegetstarted/README.md Outdated Show resolved Hide resolved
javascriptv3/example_code/nodegetstarted/README.md Outdated Show resolved Hide resolved
@lkdavies lkdavies added Text Review complete Text review complete and removed Text Review needed This work needs editorial (text) review labels Sep 27, 2023
@cpyle0819 cpyle0819 requested review from a team and ford-at-aws and removed request for beqqrry-aws and a team September 28, 2023 13:08
@meyertst-aws meyertst-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 2, 2023
@meyertst-aws meyertst-aws force-pushed the corepyle/cleanup-nodegetstarted branch from f9bba41 to 7df20fb Compare October 2, 2023 13:12
@meyertst-aws meyertst-aws merged commit cf2df3b into awsdocs:main Oct 2, 2023
9 checks passed
@cpyle0819 cpyle0819 deleted the corepyle/cleanup-nodegetstarted branch October 2, 2023 23:02
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Text Review complete Text review complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants