Rust: Checks use -D warnings #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSouther
added
Rust
rcoh
approved these changes
Oct 3, 2023
DavidSouther
force-pushed
the
rust/checks/D_warnings
branch
from
1330914
to
9de72c9
Compare
DavidSouther
added
On Call Review needed
DavidSouther
force-pushed
the
rust/checks/D_warnings
branch
from
9de72c9
to
6276b03
Compare
DavidSouther
force-pushed
the
rust/checks/D_warnings
branch
from
6276b03
to
366e9ca
Compare
rlhagerm
approved these changes
Oct 4, 2023
rlhagerm
added
On Call Review complete
ford-at-aws
pushed a commit
that referenced
this pull request
Dec 15, 2023
* Consistently use -D warnings, and add Lambdas to checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistently use -D warnings, and add Lambdas to checks. It was inconsistently used on the command line, this sets it in RUSTFLAGS for the GitHub action for all builds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.