Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript (v3): Ramdectomy #5481

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Conversation

cpyle0819
Copy link
Contributor

This pull request removes Ramda from the codebase. Ramda usage makes the code difficult to read and the library is poorly typed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 added Text Review not needed This contains no text which needs review Task labels Oct 10, 2023
@cpyle0819 cpyle0819 requested a review from a team October 10, 2023 13:18
@cpyle0819 cpyle0819 self-assigned this Oct 10, 2023
@cpyle0819 cpyle0819 requested review from beqqrry-aws and a team and removed request for a team and beqqrry-aws October 10, 2023 13:18
@github-actions github-actions bot added Javascript-v3 This issue relates to the AWS SDK for Javascript V3 CDK Relates to the AWS Cloud Development Kit (CDK) labels Oct 10, 2023
@cpyle0819 cpyle0819 requested review from a team and ford-at-aws and removed request for a team October 10, 2023 13:18
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cpyle0819 cpyle0819 added the On Call Review needed This work needs an on-call review label Oct 10, 2023
@ford-at-aws ford-at-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 10, 2023
@ford-at-aws ford-at-aws merged commit 341c6ad into awsdocs:main Oct 11, 2023
9 checks passed
@cpyle0819 cpyle0819 deleted the corepyle/ramdaectomy branch October 11, 2023 16:12
ford-at-aws added a commit that referenced this pull request Dec 15, 2023
* JavaScript (v3): Ramdaectomy - Remove ramda usage from cognito-identity-provider.

* JavaScript (v3): Ramdaectomy - Remove ramda usage from aurora-serverless-app.

* JavaScript (v3): Ramdaectomy - Remove ramda usage from glue.

* JavaScript (v3): Ramdaectomy - Remove ramda usage from lambda.

* JavaScript (v3): Ramdaectomy - Remove ramda usage cmd-runner.

* JavaScript (v3): Ramdaectomy - Remove remaining ramda usage.

* JavaScript (v3): Ramdaectomy - Add missing copyright.

---------

Co-authored-by: ford prior <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Relates to the AWS Cloud Development Kit (CDK) Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants