Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: Updates for Swift SDK 0.28.0 #5498

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

shepazon
Copy link
Contributor

@shepazon shepazon commented Oct 13, 2023

Updated tests to use the new names for return structs. The old *OutputResponse types are now *Output.

The affected tests are the ones for s3/ListBuckets, ddb/ListTables, and swift-sdk/mocking.

There's a build on my cloud desktop at http://sheppycloud.aka.corp.amazon.com:4302/swift_1_code_examples.html but these changes only affect the tests, so this won't really show anything useful.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the Swift This issue relates to the AWS SDK for Swift label Oct 13, 2023
@shepazon shepazon self-assigned this Oct 13, 2023
@shepazon shepazon added On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review labels Oct 13, 2023
@shepazon shepazon marked this pull request as draft October 13, 2023 16:48
@shepazon shepazon marked this pull request as ready for review October 13, 2023 19:17
Updated tests to use the new names for return structs.
The old *OutputResponse types are now *Output.
@ford-at-aws ford-at-aws added On Call Review complete On call review complete Task and removed On Call Review needed This work needs an on-call review labels Oct 13, 2023
@ford-at-aws ford-at-aws merged commit bf45b05 into awsdocs:main Oct 13, 2023
16 of 17 checks passed
rlhagerm pushed a commit to rlhagerm/aws-doc-sdk-examples that referenced this pull request Oct 16, 2023
Updates for Swift SDK 0.28.0

Updated tests to use the new names for return structs.
The old *OutputResponse types are now *Output.
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
Updates for Swift SDK 0.28.0

Updated tests to use the new names for return structs.
The old *OutputResponse types are now *Output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Call Review complete On call review complete Swift This issue relates to the AWS SDK for Swift Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants