Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Moved tools to .tools from .doc_gen and added Python tools rules. #5516

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

DavidSouther
Copy link
Contributor

Closes #5443


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@DavidSouther DavidSouther self-assigned this Oct 16, 2023
@github-actions github-actions bot added the Tools label Oct 16, 2023
@github-actions github-actions bot added the GitHub settings This affects GitHub settings label Oct 16, 2023
.tools/verify_python.ps Outdated Show resolved Hide resolved
.tools/base_requirements.txt Outdated Show resolved Hide resolved
.tools/README.md Outdated Show resolved Hide resolved
.tools/README.md Outdated Show resolved Hide resolved
.tools/README.md Outdated Show resolved Hide resolved
.tools/README.md Outdated Show resolved Hide resolved
.tools/README.md Outdated Show resolved Hide resolved
.tools/README.md Outdated Show resolved Hide resolved
.tools/README.md Outdated Show resolved Hide resolved
.tools/README.md Outdated Show resolved Hide resolved
@cpyle0819
Copy link
Contributor

Hehe... "tools rules"

@cpyle0819
Copy link
Contributor

Couple of questions, but no comments from me.

Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavidSouther DavidSouther force-pushed the tools/python/rules branch 2 times, most recently from 5455a70 to 505e5d1 Compare October 17, 2023 19:33
Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

.tools/README.md Show resolved Hide resolved
.tools/README.md Show resolved Hide resolved
.tools/README.md Show resolved Hide resolved
.tools/README.md Show resolved Hide resolved
.tools/README.md Show resolved Hide resolved
.tools/README.md Show resolved Hide resolved
.tools/README.md Show resolved Hide resolved
.tools/README.md Show resolved Hide resolved
.tools/README.md Show resolved Hide resolved
.tools/README.md Show resolved Hide resolved
@DavidSouther DavidSouther added the Text Review needed This work needs editorial (text) review label Oct 17, 2023
@lkdavies lkdavies added Text Review complete Text review complete and removed Text Review needed This work needs editorial (text) review labels Oct 17, 2023
@DavidSouther DavidSouther added the On Call Review needed This work needs an on-call review label Oct 17, 2023
@cpyle0819 cpyle0819 added the Task label Oct 18, 2023
@cpyle0819 cpyle0819 dismissed Laren-AWS’s stale review October 18, 2023 14:16

Changes addressed.

@cpyle0819 cpyle0819 added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 18, 2023
@DavidSouther DavidSouther force-pushed the tools/python/rules branch 2 times, most recently from 9c09a18 to e756c5f Compare October 18, 2023 17:42
@cpyle0819 cpyle0819 merged commit c2e4fdb into awsdocs:main Oct 18, 2023
8 checks passed
@DavidSouther DavidSouther deleted the tools/python/rules branch October 23, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub settings This affects GitHub settings On Call Review complete On call review complete Text Review complete Text review complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tools: Document preferred tooling environment
6 participants