-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Moved tools to .tools from .doc_gen and added Python tools rules. #5516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSouther
force-pushed
the
tools/python/rules
branch
from
October 16, 2023 21:46
5c640e9
to
0617d78
Compare
Laren-AWS
previously requested changes
Oct 16, 2023
Hehe... "tools rules" |
cpyle0819
reviewed
Oct 17, 2023
cpyle0819
reviewed
Oct 17, 2023
Couple of questions, but no comments from me. |
ford-at-aws
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
DavidSouther
force-pushed
the
tools/python/rules
branch
2 times, most recently
from
October 17, 2023 19:33
5455a70
to
505e5d1
Compare
lkdavies
reviewed
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial comments
DavidSouther
added
the
Text Review needed
This work needs editorial (text) review
label
Oct 17, 2023
lkdavies
added
Text Review complete
Text review complete
and removed
Text Review needed
This work needs editorial (text) review
labels
Oct 17, 2023
cpyle0819
force-pushed
the
tools/python/rules
branch
from
October 18, 2023 14:16
5e17084
to
80468d1
Compare
cpyle0819
added
On Call Review complete
On call review complete
and removed
On Call Review needed
This work needs an on-call review
labels
Oct 18, 2023
DavidSouther
force-pushed
the
tools/python/rules
branch
2 times, most recently
from
October 18, 2023 17:42
9c09a18
to
e756c5f
Compare
cpyle0819
force-pushed
the
tools/python/rules
branch
from
October 18, 2023 19:41
edec816
to
41ebe28
Compare
ford-at-aws
pushed a commit
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GitHub settings
This affects GitHub settings
On Call Review complete
On call review complete
Text Review complete
Text review complete
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5443
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.