Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET v3: CloudWatch logs - fix logic so it will iterate over NextToken #5555

Merged

Conversation

finalcut
Copy link
Contributor

This pull request fixes a logic error in the DescribeLogGroupsAsync process. Previously the NextToken value was never used and if you had more than 5 LogGroups; which would cause NextToken to have a value, the code would enter an infinite loop


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the DotNet-v3 This issue relates to the AWS SDK for .NET V3 label Oct 23, 2023
@finalcut
Copy link
Contributor Author

this PR is related to issue 5517
#5517

@rlhagerm rlhagerm changed the title fix logic so it will iterate over NextToken .NET v3: CloudWatch logs - fix logic so it will iterate over NextToken Oct 23, 2023
Bill Rawlinson added 2 commits October 23, 2023 11:36
@finalcut
Copy link
Contributor Author

i think I fixed the linter problem

@finalcut
Copy link
Contributor Author

thanks @rlhagerm I just noticed my extra brace

Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small formatting and braces fix. Ran it on a larger log group, looks good.

@rlhagerm rlhagerm added On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review Task labels Oct 23, 2023
@cpyle0819 cpyle0819 added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 23, 2023
@cpyle0819 cpyle0819 merged commit 170b53c into awsdocs:main Oct 23, 2023
17 of 23 checks passed
@finalcut finalcut deleted the 5517-csharp-describe-log-groups-request branch October 23, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DotNet-v3 This issue relates to the AWS SDK for .NET V3 On Call Review complete On call review complete Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants