-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET v3: CloudWatch logs - fix logic so it will iterate over NextToken #5555
Merged
cpyle0819
merged 5 commits into
awsdocs:main
from
finalcut:5517-csharp-describe-log-groups-request
Oct 23, 2023
Merged
.NET v3: CloudWatch logs - fix logic so it will iterate over NextToken #5555
cpyle0819
merged 5 commits into
awsdocs:main
from
finalcut:5517-csharp-describe-log-groups-request
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
DotNet-v3
This issue relates to the AWS SDK for .NET V3
label
Oct 23, 2023
this PR is related to issue 5517 |
rlhagerm
changed the title
fix logic so it will iterate over NextToken
.NET v3: CloudWatch logs - fix logic so it will iterate over NextToken
Oct 23, 2023
…finalcut/aws-doc-sdk-examples into 5517-csharp-describe-log-groups-request
i think I fixed the linter problem |
thanks @rlhagerm I just noticed my extra brace |
rlhagerm
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a small formatting and braces fix. Ran it on a larger log group, looks good.
rlhagerm
added
On Call Review needed
This work needs an on-call review
Text Review not needed
This contains no text which needs review
Task
labels
Oct 23, 2023
cpyle0819
added
On Call Review complete
On call review complete
and removed
On Call Review needed
This work needs an on-call review
labels
Oct 23, 2023
ford-at-aws
pushed a commit
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DotNet-v3
This issue relates to the AWS SDK for .NET V3
On Call Review complete
On call review complete
Text Review not needed
This contains no text which needs review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a logic error in the DescribeLogGroupsAsync process. Previously the NextToken value was never used and if you had more than 5 LogGroups; which would cause NextToken to have a value, the code would enter an infinite loop
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.