Java v2: Update presign URL with PUT to show file and update other examples #5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Java-v2
tkhill-AWS
changed the title
scmacdon
approved these changes
Oct 24, 2023
scmacdon
added
On Call Review complete
ford-at-aws
pushed a commit
that referenced
this pull request
Dec 15, 2023
…amples (#5558) * Create presigned URL example that puts a file https://sim.amazon.com/issues/V1071818812 * remove unused or replaced files; remove metadata.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request...updates code examples for S3 presigning for PUT requests. The Java dev guide contained an example that used metadata and uploaded a string, but customers have expressed interesting in seeing examples that upload files, such as PDF files. So the Java dev guide will use a new file
GeneratePresignedUrlAndPutFileWithMetadata.javain place ofGeneratePresignedUrlMetadata.java.The content for file
GeneratePresignedUrlUploadImagewas never used, so it has been deleted.The file used in SoS examples,
GeneratePresignedUrlAndUploadObject.java, has been updated with a JDK 11 HttpClient example to upload the String, in addition to theHttpURLConnectionexample. The uploading code has been separated from the code that creates the presigned URL, to make it the distinction clearer.The updated content for the SoS examples is here as the first example with the title, Create a presigned URL.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.