Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpp: Removed superceded starter project #5572

Merged

Conversation

meyertst-aws
Copy link
Contributor

@meyertst-aws meyertst-aws commented Oct 25, 2023

Before there was Hello Service, this general project served as a starting point. References to it have been removed in the CPP Dev guide and replace by Hello S3.
The "general" project is now redundant, and this PR removes it.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@meyertst-aws meyertst-aws added C++ This issue relates to the AWS SDK for C++ Text Review not needed This contains no text which needs review Task labels Oct 25, 2023
@meyertst-aws meyertst-aws requested a review from a team October 25, 2023 15:57
@meyertst-aws meyertst-aws self-assigned this Oct 25, 2023
@meyertst-aws meyertst-aws requested review from cpyle0819 and removed request for a team October 25, 2023 15:57
@cpyle0819
Copy link
Contributor

Was there any SOS metadata affected by this?

@meyertst-aws meyertst-aws added the On Call Review needed This work needs an on-call review label Oct 25, 2023
@scmacdon scmacdon added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 25, 2023
@scmacdon scmacdon force-pushed the 5407-cpp-remove-redundant-starter-project branch from 2bbdbcd to 366a782 Compare October 25, 2023 17:25
@scmacdon scmacdon merged commit c6e43a4 into awsdocs:main Oct 25, 2023
@meyertst-aws meyertst-aws deleted the 5407-cpp-remove-redundant-starter-project branch November 6, 2023 14:16
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
These files are superceded by the service hello worlds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ This issue relates to the AWS SDK for C++ On Call Review complete On call review complete Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants