-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Weathertop - Update testing stack #5579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nit: Prefix the PR title with |
DavidSouther
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of moving pieces in this PR - updates to the code, new docs, and activating for several languages. Let's pull this into a few PRs so each can get the attention it is due.
ford-at-aws
changed the title
Tools: Update testing stack
Tools: Weathertop - Update testing stack
Oct 27, 2023
ford-at-aws
added
On Call Review needed
This work needs an on-call review
Text Review not needed
This contains no text which needs review
Task
labels
Oct 27, 2023
ford-at-aws
force-pushed
the
test-updates
branch
from
October 27, 2023 19:30
b3a013f
to
2f8dc4e
Compare
DavidSouther
requested changes
Oct 27, 2023
.tools/test/eventbridge_rule_with_sns_fanout/producer_stack/producer_stack.py
Show resolved
Hide resolved
.tools/test/sqs_lambda_to_batch_fargate/consumer_stack/consumer_stack.py
Show resolved
Hide resolved
DavidSouther
approved these changes
Oct 27, 2023
.tools/test/eventbridge_rule_with_sns_fanout/producer_stack/producer_stack.py
Show resolved
Hide resolved
.tools/test/sqs_lambda_to_batch_fargate/consumer_stack/consumer_stack.py
Show resolved
Hide resolved
Laren-AWS
added
On Call Review complete
On call review complete
and removed
On Call Review needed
This work needs an on-call review
labels
Oct 31, 2023
ford-at-aws
force-pushed
the
test-updates
branch
from
November 1, 2023 15:49
7565378
to
c109017
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
On Call Review complete
On call review complete
Text Review not needed
This contains no text which needs review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds necessary updates to the testing stacks to support deployment of both Producer and Consumer testing stacks.
These changes have been deployed to our test accounts and I am versioning them here in the aftermath of those deployments.