Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript (v3): Update Dockerfile to correctly build for, and run, integ tests. #5589

Merged
merged 2 commits into from
Nov 1, 2023
Merged

JavaScript (v3): Update Dockerfile to correctly build for, and run, integ tests. #5589

merged 2 commits into from
Nov 1, 2023

Conversation

cpyle0819
Copy link
Contributor

This pull request reconciles some Weathertop changes with the JavaScript docker file. Specifically, it does the following:

  • Ensure current docker user owns the working directories
  • Copies over necessary resources
  • Fixes a few ornery integration tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 added On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review Task labels Oct 30, 2023
@cpyle0819 cpyle0819 requested a review from a team October 30, 2023 21:38
@cpyle0819 cpyle0819 self-assigned this Oct 30, 2023
@cpyle0819 cpyle0819 requested review from scmacdon and ford-at-aws and removed request for a team and scmacdon October 30, 2023 21:38
@github-actions github-actions bot added Javascript-v3 This issue relates to the AWS SDK for Javascript V3 and removed Task labels Oct 30, 2023
ford-at-aws
ford-at-aws approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I foresee issues with these changes but we can cross that bridge when we come to it.

@Laren-AWS Laren-AWS added On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. and removed On Call Review needed This work needs an on-call review labels Nov 1, 2023
@Laren-AWS Laren-AWS merged commit 5c372a3 into awsdocs:main Nov 1, 2023
15 of 18 checks passed
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
@cpyle0819 @ford-at-aws
JavaScript (v3): Update Dockerfile to correctly build for, and run, i…
557f64b 
…nteg tests. (#5589)

* JavaScript (v3): Update scripts location in dockerfile and log all test output
* JavaScript (v3): Update docker file to correctly run integ tests.
@cpyle0819 cpyle0819 deleted the corepyle/dockerfile branch January 4, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ford-at-aws ford-at-aws ford-at-aws approved these changes

Assignees

@cpyle0819 cpyle0819

Labels
Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. Text Review not needed This contains no text which needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpyle0819 @ford-at-aws @Laren-AWS