Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools - PHP: Fixes for Dockerfile #5592

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Tools - PHP: Fixes for Dockerfile #5592

merged 3 commits into from
Nov 2, 2023

Conversation

ford-at-aws
Copy link
Contributor

This PR fixes some bad Dockerfile lines which attempted to implement Debian commands on Alpine.

@ford-at-aws ford-at-aws added PHP This issue relates to the AWS SDK for PHP On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review Task labels Oct 31, 2023
@ford-at-aws ford-at-aws self-assigned this Oct 31, 2023
@ford-at-aws ford-at-aws marked this pull request as ready for review October 31, 2023 14:34
@github-actions github-actions bot removed the Tools label Oct 31, 2023
@ford-at-aws ford-at-aws changed the title Tools - Testing PHP: Fixes for Dockerfile Tools - PHP: Fixes for Dockerfile Oct 31, 2023
@github-actions github-actions bot removed the Task label Nov 1, 2023
@Laren-AWS Laren-AWS added Task A general update to the code base for language clarification, missing actions, tests, etc. On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Nov 2, 2023
@Laren-AWS Laren-AWS merged commit f5b0ba7 into main Nov 2, 2023
8 checks passed
@Laren-AWS Laren-AWS deleted the fix-php branch November 2, 2023 21:52
ford-at-aws added a commit that referenced this pull request Dec 15, 2023
@ford-at-aws
Tools - PHP: Fixes for Dockerfile (#5592)
ece0acb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidSouther DavidSouther DavidSouther approved these changes

Assignees

@ford-at-aws ford-at-aws

Labels
On Call Review complete On call review complete PHP This issue relates to the AWS SDK for PHP Task A general update to the code base for language clarification, missing actions, tests, etc. Text Review not needed This contains no text which needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ford-at-aws @DavidSouther @Laren-AWS