-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Consolidated validators to .tools/validation #5597
Merged
Laren-AWS
merged 7 commits into
awsdocs:main
from
DavidSouther:tools/validators/combine_gh
Nov 3, 2023
Merged
Tools: Consolidated validators to .tools/validation #5597
Laren-AWS
merged 7 commits into
awsdocs:main
from
DavidSouther:tools/validators/combine_gh
Nov 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSouther
force-pushed
the
tools/validators/combine_gh
branch
from
November 1, 2023 00:44
a99ae7e
to
785a49d
Compare
github-actions
bot
added
Tools
This issue relates to a custom tooling to streamline development tasks
and removed
Task
labels
Nov 1, 2023
Laren-AWS
requested changes
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add node_modules
to the top-level .gitignore? I have a few of them in my local clone for some reason that aren't captured in other .gitignore files and I suspect others might as well.
DavidSouther
force-pushed
the
tools/validators/combine_gh
branch
from
November 2, 2023 20:06
ac374d1
to
cfa20cd
Compare
Done and son. |
DavidSouther
force-pushed
the
tools/validators/combine_gh
branch
from
November 2, 2023 20:07
cfa20cd
to
571f2cd
Compare
Laren-AWS
approved these changes
Nov 2, 2023
Laren-AWS
added
Task
A general update to the code base for language clarification, missing actions, tests, etc.
On Call Review complete
On call review complete
Text Review not needed
This contains no text which needs review
labels
Nov 2, 2023
Laren-AWS
force-pushed
the
tools/validators/combine_gh
branch
from
November 2, 2023 21:58
571f2cd
to
a1d263a
Compare
DavidSouther
force-pushed
the
tools/validators/combine_gh
branch
from
November 3, 2023 00:14
a1d263a
to
23ba7a4
Compare
Better snippet validation workflow name
Laren-AWS
force-pushed
the
tools/validators/combine_gh
branch
from
November 3, 2023 00:52
3014147
to
b79ab56
Compare
ford-at-aws
pushed a commit
that referenced
this pull request
Dec 15, 2023
* Consolidated validators to .tools/validation, and reworked file walker * Better snippet validation workflow name * bump to python 3.11 * Commented validators * Cleaned up IGNORE_FILES checks between walk... and git...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
GitHub settings
This affects GitHub settings
On Call Review complete
On call review complete
Task
A general update to the code base for language clarification, missing actions, tests, etc.
Text Review not needed
This contains no text which needs review
Tools
This issue relates to a custom tooling to streamline development tasks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves pre_validate and validate_doc_metadata into .tools/validation. Each can be run individually, and there's a new
validate.py
that runs both.Also reworked the walker in
project_validator
(nee pre_validate), which should also get used in Writme'ssnippet.py
.Part of #5453
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.