Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Consolidated validators to .tools/validation #5597

Merged
merged 7 commits into from
Nov 3, 2023

Conversation

DavidSouther
Copy link
Contributor

@DavidSouther DavidSouther commented Oct 31, 2023

This pull request moves pre_validate and validate_doc_metadata into .tools/validation. Each can be run individually, and there's a new validate.py that runs both.

Also reworked the walker in project_validator (nee pre_validate), which should also get used in Writme's snippet.py.

Part of #5453


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@DavidSouther DavidSouther self-assigned this Oct 31, 2023
@github-actions github-actions bot added the GitHub settings This affects GitHub settings label Oct 31, 2023
@github-actions github-actions bot added Tools This issue relates to a custom tooling to streamline development tasks and removed Task labels Nov 1, 2023
Copy link
Contributor

@Laren-AWS Laren-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add node_modules to the top-level .gitignore? I have a few of them in my local clone for some reason that aren't captured in other .gitignore files and I suspect others might as well.

.tools/validation/metadata_validator.py Outdated Show resolved Hide resolved
@DavidSouther
Copy link
Contributor Author

Done and son.

@Laren-AWS Laren-AWS added Task A general update to the code base for language clarification, missing actions, tests, etc. On Call Review complete On call review complete Text Review not needed This contains no text which needs review labels Nov 2, 2023
@Laren-AWS Laren-AWS merged commit 7b42a3f into awsdocs:main Nov 3, 2023
8 checks passed
@DavidSouther DavidSouther deleted the tools/validators/combine_gh branch November 6, 2023 16:58
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
* Consolidated validators to .tools/validation, and reworked file walker
* Better snippet validation workflow name
* bump to python 3.11
* Commented validators
* Cleaned up IGNORE_FILES checks between walk... and git...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub settings This affects GitHub settings On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. Text Review not needed This contains no text which needs review Tools This issue relates to a custom tooling to streamline development tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants