Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpp: remove duplicate instance classes for DescribeOrderableDBInstanceOptions #6126

Conversation

meyertst-aws
Copy link
Contributor

Remove duplicates when listing instance classes. This responds to an issue raised by @max-webster.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@meyertst-aws meyertst-aws added C++ This issue relates to the AWS SDK for C++ Text Review not needed This contains no text which needs review Bug An update to fix incorrect code or typos. labels Feb 16, 2024
@meyertst-aws meyertst-aws requested a review from a team February 16, 2024 19:30
@meyertst-aws meyertst-aws self-assigned this Feb 16, 2024
@meyertst-aws meyertst-aws requested review from beqqrry-aws and removed request for a team February 16, 2024 19:30
@github-actions github-actions bot added GitHub settings This affects GitHub settings and removed GitHub settings This affects GitHub settings labels Feb 16, 2024
@meyertst-aws meyertst-aws added the On Call Review needed This work needs an on-call review label Feb 16, 2024
@meyertst-aws meyertst-aws removed the On Call Review needed This work needs an on-call review label Feb 19, 2024
@meyertst-aws meyertst-aws force-pushed the 6099-bug-awsdocaurorachoosedbinstanceclass-function-lists-instance-classes-twice branch from 4c4da3f to 768a684 Compare February 19, 2024 20:35
@github-actions github-actions bot added the GitHub settings This affects GitHub settings label Feb 19, 2024
@meyertst-aws meyertst-aws added the On Call Review needed This work needs an on-call review label Feb 19, 2024
@github-actions github-actions bot removed the GitHub settings This affects GitHub settings label Feb 19, 2024
@ford-at-aws ford-at-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Feb 22, 2024
@ford-at-aws ford-at-aws merged commit 365bd81 into awsdocs:main Feb 22, 2024
10 checks passed
meyertst-aws added a commit to meyertst-aws/aws-doc-sdk-examples that referenced this pull request Feb 28, 2024
max-webster pushed a commit to max-webster/aws-doc-sdk-examples that referenced this pull request Mar 15, 2024
@meyertst-aws meyertst-aws deleted the 6099-bug-awsdocaurorachoosedbinstanceclass-function-lists-instance-classes-twice branch March 27, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An update to fix incorrect code or typos. C++ This issue relates to the AWS SDK for C++ On Call Review complete On call review complete Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants