Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript (v3): Add package validation script. #6167

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

cpyle0819
Copy link
Contributor

This pull request adds a step to the javascript GitHub action. The action will check all package names in the workspace to make sure they're scoped to @aws-doc-sdk-examples


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 added the Task A general update to the code base for language clarification, missing actions, tests, etc. label Feb 22, 2024
@cpyle0819 cpyle0819 self-assigned this Feb 22, 2024
@github-actions github-actions bot added Javascript-v3 This issue relates to the AWS SDK for Javascript V3 GitHub settings This affects GitHub settings labels Feb 22, 2024
@cpyle0819 cpyle0819 force-pushed the corepyle/package-validation branch 5 times, most recently from 5713330 to 9577e9e Compare February 23, 2024 14:18
@cpyle0819 cpyle0819 added the On Call Review needed This work needs an on-call review label Feb 23, 2024
@cpyle0819 cpyle0819 requested review from a team and ford-at-aws and removed request for a team February 23, 2024 14:21
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, great idea

@ford-at-aws ford-at-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Feb 23, 2024
@ford-at-aws ford-at-aws merged commit fdbfc92 into main Feb 23, 2024
14 of 15 checks passed
@ford-at-aws ford-at-aws deleted the corepyle/package-validation branch February 23, 2024 16:32
meyertst-aws pushed a commit to meyertst-aws/aws-doc-sdk-examples that referenced this pull request Feb 28, 2024
max-webster pushed a commit to max-webster/aws-doc-sdk-examples that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GitHub settings This affects GitHub settings Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants