Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release workflows #40

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Add release workflows #40

merged 4 commits into from
Apr 19, 2024

Conversation

tonykchen
Copy link
Contributor

@tonykchen tonykchen commented Apr 18, 2024 •
edited
Loading

Issue #, if available:
Closes #37

Description of changes:

  • Added 2 workflows which run when we create a GitHub release:
    1. Publish documentation with GitHub Pages
    2. Publish package to PyPI
  • Removed kwargs argument from docstrings to fix warnings when building docs
  • Added Bedrock knowledge base docs to mkdocs.yml

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tonykchen tonykchen force-pushed the add-release-workflows branch from 045f13d to 26070b6 Compare April 18, 2024 23:32
@tonykchen tonykchen marked this pull request as ready for review April 19, 2024 03:15
sharonxiaohanli
sharonxiaohanli approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@sharonxiaohanli sharonxiaohanli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharonxiaohanli sharonxiaohanli merged commit 14ac156 into main Apr 19, 2024
4 checks passed
@tonykchen tonykchen deleted the add-release-workflows branch April 19, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharonxiaohanli sharonxiaohanli sharonxiaohanli approved these changes

@bobbywlindsey bobbywlindsey Awaiting requested review from bobbywlindsey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement release pipelines
2 participants
@tonykchen @sharonxiaohanli