This repository has been archived by the owner on Aug 22, 2024. It is now read-only.
Added not-encrypted flag to install script #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added not-encrypted flag to the install script as its turned on by default and if we wanted to turn it off, the only way is to modify
ebs-autoscale.json. As we run this install script as part of launch template user data, it would be nice to have a flag passed to install script to disable that if needed. Like below,./install.sh --file-system lvm.ext4 --mountpoint "/storage" --volume-type "gp3" --initial-size 100 --min-ebs-volume-size 200 --max-ebs-volume-size 1000 --max-total-created-size 2000 --max-attached-volumes 10 --initial-utilization-threshold 50 --not-encryptedBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.