cleanup nerdctl after nodeadm containerized build #1599
Conversation
| @@ -13,6 +13,10 @@ sudo nerdctl run \ | |||
| public.ecr.aws/eks-distro-build-tooling/golang:1.21 \ | |||
| make build | |||
|
|
|||
| # cleanup images and networks used for nerdctl | |||
There was a problem hiding this comment.
do we need to add corresponding test/verification after AMI build?
There was a problem hiding this comment.
can definitely do this, let me see if i can setup a comprehensive validation
There was a problem hiding this comment.
what test would be most effective? not 100% sure about network guarantees, like checking interface names/count. the existence of nerdctl0 is crude but works i guess. any thoughts?
There was a problem hiding this comment.
I think at build AMI level, check the existence of nerdctl0 would be a good start point
|
having issues with key-value not being parsed correctly? |
ndbaker1
force-pushed
the
nerdctl-cleanup
branch
2 times, most recently
from
595e1df to
bbb7256
Compare
|
resorted to a more direct method of parsing |
ndbaker1
force-pushed
the
nerdctl-cleanup
branch
from
bbb7256 to
4700fa1
Compare
Issue #, if available:
Description of changes:
cleanup network and image resources used by nerdctl during the nodeadm build
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
capture the following in between steps of the build:
after build:
after cleanup: (the additions in the PR)
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.