-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): add nodeadm wasm targets to call from docs #2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
ndbaker1
force-pushed
the
wasm-checker
branch
2 times, most recently
from
December 10, 2024 01:14
034a286
to
d1367ca
Compare
ndbaker1
changed the title
experiment: compiling wasm for use in docs
feat(docs): add nodeadm wasm targets to call from docs
Dec 10, 2024
ndbaker1
force-pushed
the
wasm-checker
branch
6 times, most recently
from
December 10, 2024 07:01
e3d663c
to
010bf46
Compare
im somewhat happy with the functionality now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing!
ndbaker1
force-pushed
the
wasm-checker
branch
from
December 10, 2024 21:44
010bf46
to
e4992e7
Compare
cartermckinnon
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
It would be helpful to be able to test a
NodeConfig
straight from the browser without installing any tools.This PR adds a WebAssembly package containing nodeadm's config parsing hook and provides a minimal editor that users can paste their config into.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
deployed to my fork's ghpages: https://ndbaker1.github.io/amazon-eks-ami/nodeadm/doc/playground/
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.