Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change list of match ids to set for json_handler.py #395

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

cmclel7
Copy link
Contributor

@cmclel7 cmclel7 commented Jan 25, 2024

Increase the speed of the json_handler by migrating from a list to a set. Move from O(n) to O(1)

Issue #, if available:

Description of changes:

PR Checklist:

  • Changelog updated
  • Unit tests (and integration tests if applicable) provided
  • All tests pass
  • Pre-commit checks pass
  • Debugging code removed
  • If releasing a new version, have you bumped the version in the main CFN template?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Increase the speed of the json_handler by migrating from a list to a set. Move from O(n) to O(1)
@cmclel7 cmclel7 requested a review from matteofigus January 25, 2024 16:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d7fd40) 99.71% compared to head (30657c5) 99.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          31       31           
  Lines        1742     1742           
=======================================
  Hits         1737     1737           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmclel7 cmclel7 marked this pull request as ready for review January 26, 2024 12:41
matteofigus
matteofigus previously approved these changes Jan 26, 2024
@cmclel7 cmclel7 merged commit 3efdceb into master Jan 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants