Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Managed Policy with equivalent inline policy #405

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

ConnorKirk
Copy link
Contributor

@ConnorKirk ConnorKirk commented Mar 26, 2024

Some scanners are triggered by the presence of the AmazonAPIGatewayInvokeFullAccessmanaged policy. This commit replaces the managed policy with an equivalent inline policy that will not trigger scanners. There's a small security win in being able to scope the API Gateway resource to the specific Account and Region.

Issue #, if available:

Description of changes:

PR Checklist:

  • Changelog updated
  • Unit tests (and integration tests if applicable) provided
  • All tests pass
  • Pre-commit checks pass
  • Debugging code removed
  • If releasing a new version, have you bumped the version in the main CFN template?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…nt inline policy.

Some scanners are triggered by the prescence of the managed policy. This commit replaces the managed policy with an equivalent inline policy that will not trigger scanners. There's a small security win in being able to scope the API Gateway resource to the specific Account and Region.
@ConnorKirk ConnorKirk force-pushed the refactor/cognito-service-invoke-role branch from 8813df7 to 2c596e2 Compare March 26, 2024 08:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (cb48fca) to head (2c596e2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #405   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          31       31           
  Lines        1742     1742           
=======================================
  Hits         1737     1737           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ConnorKirk ConnorKirk marked this pull request as ready for review March 26, 2024 08:27
@matteofigus matteofigus merged commit e2af516 into master Mar 26, 2024
7 checks passed
@matteofigus matteofigus deleted the refactor/cognito-service-invoke-role branch March 26, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants