Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Scan On Push for the ECR Repository #408

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

nickdengamazon
Copy link
Contributor

@nickdengamazon nickdengamazon commented Apr 5, 2024

Image scanning helps in identifying software vulnerabilities in your container images. Each repository can be configured to scan on push. This ensures that each new image pushed to the repository is scanned. You can then retrieve the results of the image scan. You can learn more here. When Scan on Push is not enabled, images are not automatically scanned when they are pushed on to the repository. Vulnerabilities in your ECR images can affect the security posture of your containers or any applications running within them. Some scanners are triggered because the ECR repository doesn't enable ScanOnPush.

Issue #, if available:

Description of changes:

Enable scan on push for the ECR repository used by the deletion workflow.

PR Checklist:

  • Changelog updated
  • All tests pass
  • Pre-commit checks pass
  • Debugging code removed
  • If releasing a new version, have you bumped the version in the main CFN template?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.71%. Comparing base (6e6e299) to head (8fdfb22).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   99.71%   99.71%           
=======================================
  Files          31       31           
  Lines        1742     1742           
=======================================
  Hits         1737     1737           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickdengamazon
Copy link
Contributor Author

Unit tests and integration tests are not provided since changes are only made in the CloudFormation templates

@nickdengamazon nickdengamazon marked this pull request as ready for review June 14, 2024 21:31
Copy link
Member

@matteofigus matteofigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matteofigus matteofigus merged commit 2db7280 into awslabs:master Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants