added automated check for macos to use or install JDK 11 #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Cohen <[email protected]>
|
Thank you for your contribution; we won't be accepting this PR as we don't officially support MacOS as a platform. |
|
Hi @AbdulR3hman, If macos is not supported, how can I install development tools by running ./tools/prepare_dev_env.sh? |
|
Can I submit another PR to explain that MacOS is not supported? Are there other reasons besides the setup for MacOS not having support? |
…stale-issue-cleanup documentation Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updated prepare_dev_env.sh to check for OSTYPE for macos/darwin to install JDK11 and switch to it automatically
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.