-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Websocket automatically responds to PING with PONG (#417)
**Issue:** The Websocket was not automatically responding to a PING with a PONG, which violates [RFC-6455 Section 5.5.2](https://www.rfc-editor.org/rfc/rfc6455#section-5.5.2) **Description of changes:** Now it does Also, remove some things: - Remove concept of `high_priority` frames. - Nothing in the RFC mentions letting control frames cut in front of data frames. Remove this complexity until there's some proven need (spoiler: there will never be a need) - Remove public access to the RSV (reserved) bits. - These are only used by extensions, which we do not currently support. Keeping these accessible in the public API can only bite us later if we ever choose to support extensions. Better to keep these private unless there's a proven need to expose them.
- Loading branch information
Showing
4 changed files
with
183 additions
and
120 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.