Skip to content

Conversation

@alextwoods
Copy link
Contributor

@alextwoods alextwoods commented Oct 15, 2025

Description of changes:

  • Adds an optional no_proxy_hosts to proxy options/config - allowing configuration of no_proxy through code rather than just ENV. The no_proxy_hosts behaves the same was as the NO_PROXY env setting added in support no_proxy exactly like CURL #522
  • move close_connection_on_server_error test to mock server instead for reliable testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alextwoods alextwoods marked this pull request as ready for review October 15, 2025 20:41
Copy link
Contributor

@TingDaoK TingDaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Just couple trivial comments. The CI failure just need to merge the latest main.

@TingDaoK TingDaoK merged commit e638eb0 into awslabs:main Oct 20, 2025
41 checks passed
quinnj pushed a commit to quinnj/aws-c-http that referenced this pull request Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants