Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mqtt5 operation timeout #333

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Mqtt5 operation timeout #333

merged 7 commits into from
Nov 7, 2023

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Oct 27, 2023

  • Adds support to override the ack timeout on a per-operation basis in the MQTT5 client

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Bret Ambrose and others added 2 commits October 25, 2023 16:20
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c475ef1) 82.41% compared to head (c68cfd7) 82.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
- Coverage   82.41%   82.37%   -0.04%     
==========================================
  Files          20       20              
  Lines        8722     8765      +43     
==========================================
+ Hits         7188     7220      +32     
- Misses       1534     1545      +11     
Files Coverage Δ
source/v5/mqtt5_options_storage.c 90.71% <100.00%> (+0.12%) ⬆️
source/v5/mqtt5_to_mqtt3_adapter.c 76.58% <100.00%> (ø)
source/v5/mqtt5_client.c 88.22% <92.98%> (-0.17%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/v5/mqtt5_client_tests.c Show resolved Hide resolved
@bretambrose bretambrose merged commit ff4b239 into main Nov 7, 2023
31 checks passed
@bretambrose bretambrose deleted the Mqtt5OperationTimeout branch November 7, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants