Fix mqtt3 suback returned qos behavior #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
- Coverage 82.41% 82.40% -0.02%
==========================================
Files 20 20
Lines 8779 8785 +6
==========================================
+ Hits 7235 7239 +4
- Misses 1544 1546 +2 ☔ View full report in Codecov by Sentry. |
sbSteveK
reviewed
Jan 10, 2024
| err |= aws_array_list_push_back(&cb_list, &subscription); | ||
| } | ||
| AWS_ASSUME(!err); | ||
| task_arg->on_suback.multi(&connection->base, packet_id, &cb_list, error_code, task_arg->on_suback_ud); | ||
| aws_array_list_clean_up(&cb_list); | ||
| } else if (task_arg->on_suback.single) { | ||
| // The topic->request.qos should be already updated to returned qos |
There was a problem hiding this comment.
Trivial: Here and below in s_subscribe_single_complete we could probably change the topic->request-qos directly instead of creating a separate returned_qos. I don't believe the topic->request is used after the point of invoking the on_suback callbacks in either case.
sbSteveK
approved these changes
Jan 10, 2024
sfod
reviewed
Jan 11, 2024
tests/v3/connection_state_test.c
Outdated
Comment on lines
1697
to
1698
| /* Subscribe to multiple topics prior to connection, make a CONNECT, have the server send PUBLISH messages, | ||
| * make sure they're received, then send a DISCONNECT. */ |
There was a problem hiding this comment.
Trivial: The test description seems to be incorrect
|
Hold off because it introduce a behavior change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The Mqtt3 client would now return
AWS_MQTT_QOS_FAILUREas qos value if the subscription failed with error code.While Mqtt3 client would directly return the request qos value. This change would introduce behavior changes in CPP, Python and NodeJS.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.