Merge branch 'main' into RequestResponseWorkspace

awslabs · Oct 29, 2024 · 4d9097a · 4d9097a
2 parents b5beb16 + 3eeab89
commit 4d9097a
Show file tree

Hide file tree

Showing 17 changed files with 80 additions and 31 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml
@@ -12,6 +12,14 @@ body:
       description: What is the problem? A clear and concise description of the bug.
     validations:
       required: true
+  - type: checkboxes
+    id: regression
+    attributes:
+      label: Regression Issue
+      description: What is a regression? If it worked in a previous version but doesn't in the latest version, it's considered a regression. In this case, please provide specific version number in the report.
+      options:
+        - label: Select this option if this issue appears to be a regression.
+          required: false
   - type: textarea
     id: expected
     attributes:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -40,6 +40,7 @@ jobs:
   linux-compat:
     runs-on: ubuntu-22.04 # latest
     strategy:
+      fail-fast: false
       matrix:
         image:
           - manylinux2014-x64

diff --git a/.github/workflows/issue-regression-labeler.yml b/.github/workflows/issue-regression-labeler.yml
@@ -0,0 +1,32 @@
+# Apply potential regression label on issues
+name: issue-regression-label
+on:
+  issues:
+    types: [opened, edited]
+jobs:
+  add-regression-label:
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    steps:
+    - name: Fetch template body
+      id: check_regression
+      uses: actions/github-script@v7
+      env: 
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        TEMPLATE_BODY: ${{ github.event.issue.body }}
+      with:
+        script: |
+          const regressionPattern = /\[x\] Select this option if this issue appears to be a regression\./i;
+          const template = `${process.env.TEMPLATE_BODY}`
+          const match = regressionPattern.test(template);
+          core.setOutput('is_regression', match);
+    - name: Manage regression label
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      run: |
+        if [ "${{ steps.check_regression.outputs.is_regression }}" == "true" ]; then
+          gh issue edit ${{ github.event.issue.number }} --add-label "potential-regression" -R ${{ github.repository }}
+        else
+          gh issue edit ${{ github.event.issue.number }} --remove-label "potential-regression" -R ${{ github.repository }}
+        fi
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.1)
+cmake_minimum_required(VERSION 3.9)
 
 if(POLICY CMP0077)
     cmake_policy(SET CMP0077 NEW)
@@ -83,40 +83,47 @@ if(BUILD_DEPS)
     add_subdirectory(crt/aws-c-common)
 
     if(UNIX AND NOT APPLE AND NOT BYO_CRYPTO)
+        include(AwsPrebuildDependency)
         if(NOT USE_OPENSSL)
-            set(DISABLE_PERL ON CACHE BOOL "Disable Perl for AWS-LC.")
-            set(DISABLE_GO ON CACHE BOOL "Disable Go for AWS-LC.")
-            set(BUILD_LIBSSL OFF CACHE BOOL "Build libssl for AWS-LC.")
 
-            # temporarily disable certain warnings as errors for the aws-lc build
-            set(OLD_CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
+            set(AWSLC_CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
 
+            # temporarily disable certain warnings as errors for the aws-lc build
             if(NOT MSVC)
                 check_c_compiler_flag(-Wno-stringop-overflow HAS_WNO_STRINGOP_OVERFLOW)
 
                 if(HAS_WNO_STRINGOP_OVERFLOW)
-                    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-stringop-overflow")
+                    set(AWSLC_CMAKE_C_FLAGS "${AWSLC_CMAKE_C_FLAGS} -Wno-stringop-overflow")
                 endif()
 
                 check_c_compiler_flag(-Wno-array-parameter HAS_WNO_ARRAY_PARAMETER)
 
                 if(HAS_WNO_ARRAY_PARAMETER)
-                    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-array-parameter")
+                    set(AWSLC_CMAKE_C_FLAGS "${AWSLC_CMAKE_C_FLAGS} -Wno-array-parameter")
                 endif()
             endif()
 
-            add_subdirectory(crt/aws-lc)
-
-            # restore previous build flags
-            set(CMAKE_C_FLAGS "${OLD_CMAKE_C_FLAGS}")
-
-            set(SEARCH_LIBCRYPTO OFF CACHE BOOL "Let S2N use libcrypto from AWS-LC.")
-        else()
-            set(SEARCH_LIBCRYPTO ON CACHE BOOL "Let S2N search libcrypto in the system.")
+            # s2n-tls uses libcrypto during its configuration, so we need to prebuild aws-lc.
+            aws_prebuild_dependency(
+                DEPENDENCY_NAME AWSLC
+                SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/crt/aws-lc
+                CMAKE_ARGUMENTS
+                    -DDISABLE_GO=ON
+                    -DDISABLE_PERL=ON
+                    -DBUILD_LIBSSL=OFF
+                    -DBUILD_TESTING=OFF
+                    -DCMAKE_C_FLAGS=${AWSLC_CMAKE_C_FLAGS}
+            )
         endif()
 
-        set(UNSAFE_TREAT_WARNINGS_AS_ERRORS OFF CACHE BOOL "Disable warnings-as-errors when building S2N")
-        add_subdirectory(crt/s2n)
+        # prebuild s2n-tls.
+        aws_prebuild_dependency(
+            DEPENDENCY_NAME S2N
+            SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/crt/s2n
+            CMAKE_ARGUMENTS
+                -DUNSAFE_TREAT_WARNINGS_AS_ERRORS=OFF
+                -DBUILD_TESTING=OFF
+        )
     endif()
 
     add_subdirectory(crt/aws-c-sdkutils)
@@ -295,6 +302,7 @@ endif()
 
 set_target_properties(${PROJECT_NAME} PROPERTIES LINKER_LANGUAGE CXX)
 set_target_properties(${PROJECT_NAME} PROPERTIES CXX_STANDARD ${CMAKE_CXX_STANDARD})
+set_target_properties(${PROJECT_NAME} PROPERTIES CXX_VISIBILITY_PRESET hidden VISIBILITY_INLINES_HIDDEN ON)
 
 aws_prepare_symbol_visibility_args(${PROJECT_NAME} "AWS_CRT_CPP")
 

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.28.3
+0.29.0
diff --git a/crt/aws-c-auth b/crt/aws-c-auth
diff --git a/crt/aws-c-cal b/crt/aws-c-cal
diff --git a/crt/aws-c-common b/crt/aws-c-common
diff --git a/crt/aws-c-compression b/crt/aws-c-compression
diff --git a/crt/aws-c-event-stream b/crt/aws-c-event-stream
diff --git a/crt/aws-c-http b/crt/aws-c-http
diff --git a/crt/aws-c-io b/crt/aws-c-io
diff --git a/crt/aws-c-s3 b/crt/aws-c-s3
diff --git a/crt/aws-c-sdkutils b/crt/aws-c-sdkutils
diff --git a/crt/aws-checksums b/crt/aws-checksums
diff --git a/crt/aws-lc b/crt/aws-lc
diff --git a/crt/s2n b/crt/s2n
+1 −1		.github/workflows/ci.yml
+1 −0		.gitignore
+1 −5		CMakeLists.txt
+2 −2		README.md
+2 −2		include/aws/auth/private/credentials_utils.h
+25 −0		source/aws_signing.c
+17 −2		source/credentials_provider_process.c
+9 −5		source/credentials_provider_profile.c
+49 −7		source/credentials_utils.c
+3 −0		tests/CMakeLists.txt
+47 −46		tests/credentials_provider_process_tests.c
+111 −76		tests/credentials_provider_sts_tests.c
+58 −0		tests/credentials_utils_tests.c
+2 −2		.github/workflows/proof_ci_resources/config.yaml
+1 −1		AWSCRTAndroidTestRunner/app/src/main/cpp/CMakeLists.txt
+3 −6		CMakeLists.txt
+15 −20		cmake/AwsCFlags.cmake
+12 −8		cmake/AwsPrebuildDependency.cmake
+9 −2		cmake/AwsSIMD.cmake
+6 −3		cmake/AwsTestHarness.cmake
+1 −1		include/aws/common/array_list.h
+2 −1		include/aws/common/atomics.h
+1 −2		include/aws/common/atomics.inl
+1 −1		include/aws/common/byte_order.h
+2 −1		include/aws/common/clock.h
+9 −4		include/aws/common/condition_variable.h
+2 −1		include/aws/common/encoding.h
+1 −2		include/aws/common/error.h
+1 −1		include/aws/common/linked_list.h
+1 −1		include/aws/common/math.h
+2 −2		include/aws/common/math.inl
+2 −1		include/aws/common/ring_buffer.h
+2 −1		include/aws/common/string.h
+2 −1		include/aws/common/zero.h
+5 −6		tests/memtrace_test.c
+212 −183		verification/cbmc/proofs/Makefile.common
+16 −9		CMakeLists.txt
+1 −1		README.md
+5 −0		include/aws/io/socket.h
+13 −54		source/future.c
+10 −1		source/posix/socket.c
+8 −2		source/s2n/s2n_tls_channel_handler.c
+6 −0		source/windows/iocp/socket.c
+24 −0		source/windows/windows_pki_utils.c
+2 −0		tests/CMakeLists.txt
+14 −0		tests/socket_test.c
+36 −0		tests/tls_handler_test.c
+16 −3		.github/workflows/ci.yml
+3 −0		.gitignore
+1 −5		CMakeLists.txt
+1 −1		README.md
+13 −5		include/aws/s3/private/s3_meta_request_impl.h
+11 −0		include/aws/s3/private/s3_util.h
+3 −0		include/aws/s3/s3.h
+57 −6		include/aws/s3/s3_client.h
+3 −0		source/s3.c
+20 −10		source/s3_auto_ranged_get.c
+4 −10		source/s3_auto_ranged_put.c
+1 −0		source/s3_buffer_pool.c
+55 −39		source/s3_client.c
+30 −17		source/s3_copy_object.c
+21 −10		source/s3_default_meta_request.c
+187 −184		source/s3_endpoint_resolver/aws_s3_endpoint_resolver_partition.c
+202 −162		source/s3_meta_request.c
+99 −21		source/s3_request_messages.c
+61 −0		source/s3_util.c
+16 −0		tests/CMakeLists.txt
+15 −0		tests/mock_s3_server/CreateMultipartUpload/request_timeout.json
+1 −0		tests/s3_buffer_pool_tests.c
+409 −251		tests/s3_data_plane_tests.c
+57 −6		tests/s3_mock_server_tests.c
+44 −0		tests/s3_s3express_client_test.c
+325 −17		tests/s3_tester.c
+35 −0		tests/s3_tester.h
+4 −0		tests/test_helper/README.md
+4 −5		tests/test_helper/test_helper.py