Skip to content

Commit

Permalink
update deprecation comments
Browse files Browse the repository at this point in the history
  • Loading branch information
xiazhvera committed Nov 29, 2023
1 parent e3fbbc2 commit fa38ec4
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 9 deletions.
2 changes: 1 addition & 1 deletion include/aws/crt/mqtt/Mqtt5Client.h
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ namespace Aws
Mqtt5ClientOptions &WithConnackTimeoutMs(uint32_t connackTimeoutMs) noexcept;

/**
* @deprecated The function is deprecated, please use `WithAckTimeoutSec`
* @deprecated The function is deprecated, please use `Mqtt5ClientOptions::WithAckTimeoutSec(uint32_t)`
*
* Sets Operation Timeout(Seconds). Time interval to wait for an ack after sending a QoS 1+ PUBLISH,
* SUBSCRIBE, or UNSUBSCRIBE before failing the operation.
Expand Down
13 changes: 7 additions & 6 deletions include/aws/crt/mqtt/Mqtt5Packets.h
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,8 @@ namespace Aws
uint16_t getReceiveMaximumFromServer() const noexcept;

/**
* @deprecated the function is deprecated, please use `getMaximumPacketSizeToServer`
* @deprecated the function is deprecated, please use
* `NegotiatedSettings::getMaximumPacketSizeToServer()`
*
* @return The maximum packet size the server is willing to accept.
*/
Expand Down Expand Up @@ -531,7 +532,7 @@ namespace Aws
uint16_t getServerKeepAliveSec() const noexcept;

/**
* @deprecated The function is deprecated, please use `getServerKeepAliveSec()`
* @deprecated The function is deprecated, please use `NegotiatedSettings::getServerKeepAliveSec()`
*
* The maximum amount of time in seconds between client packets. The client should use PINGREQs to
* ensure this limit is not breached. The server will disconnect the client for inactivity if no MQTT
Expand Down Expand Up @@ -957,7 +958,7 @@ namespace Aws
const Crt::Optional<uint16_t> &getReceiveMaximum() const noexcept;

/**
* @deprecated The function is deprecated, please use `getMaximumPacketSizeToServer`
* @deprecated The function is deprecated, please use `ConnectPacket::getMaximumPacketSizeToServer()`
*
* Notifies the server of the maximum packet size the client is willing to handle. If
* omitted or null, then no limit beyond the natural limits of MQTT packet size is requested.
Expand Down Expand Up @@ -1209,7 +1210,7 @@ namespace Aws
const Crt::Optional<uint32_t> &getSessionExpiryIntervalSec() const noexcept;

/**
* @deprecated The function is deprecated, please use `getSessionExpiryIntervalSec`.
* @deprecated The function is deprecated, please use `ConnAckPacket::getSessionExpiryIntervalSec()`.
*
* A time interval, in seconds, that the server will persist this connection's MQTT session state
* for. If present, this value overrides any session expiry specified in the preceding CONNECT packet.
Expand Down Expand Up @@ -1352,7 +1353,7 @@ namespace Aws
const Crt::Optional<uint16_t> &getServerKeepAliveSec() const noexcept;

/**
* @deprecated The function is deprecated, please use `getServerKeepAliveSec`.
* @deprecated The function is deprecated, please use `ConnAckPacket::getServerKeepAliveSec()`.
* Server-requested override of the keep alive interval, in seconds. If null, the keep alive value sent
* by the client should be used.
*
Expand Down Expand Up @@ -1940,7 +1941,7 @@ namespace Aws
Subscription &WithRetainAsPublished(bool retain) noexcept;

/**
* @deprecated The function is deprecated, please use `WithRetainAsPublished`.
* @deprecated The function is deprecated, please use `Subscription::WithRetainAsPublished(bool)`.
*
* Sets should the server not send publishes to a client when that client was the one who sent the
* publish? The value will be default to false.
Expand Down
2 changes: 1 addition & 1 deletion include/aws/crt/mqtt/Mqtt5Types.h
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ namespace Aws
aws_exponential_backoff_jitter_mode::AWS_EXPONENTIAL_BACKOFF_JITTER_DECORRELATED,
};

/** @deprecated JitterMode is deprecated, please use ExponentialBackoffJitterMode */
/** @deprecated JitterMode is deprecated, please use Aws::Crt::Mqtt5::ExponentialBackoffJitterMode */
using JitterMode = ExponentialBackoffJitterMode;

/**
Expand Down
2 changes: 1 addition & 1 deletion include/aws/iot/Mqtt5Client.h
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ namespace Aws
Mqtt5ClientBuilder &WithAckTimeoutSec(uint32_t ackTimeoutSec) noexcept;

/**
* @deprecated the function is deprecated, please use `WithAckTimeoutSec`
* @deprecated the function is deprecated, please use `Mqtt5ClientBuilder::WithAckTimeoutSec(uint32_t)`
*
* Sets Operation Timeout(Seconds). Time interval to wait for an ack after sending a QoS 1+ PUBLISH,
* SUBSCRIBE, or UNSUBSCRIBE before failing the operation.
Expand Down

0 comments on commit fa38ec4

Please sign in to comment.