This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 802
nitro_check_script.sh configure NVMe io_timeout #210
Open
iitggithub
wants to merge
22
commits into
awslabs:master
Choose a base branch
from
iitggithub:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added support for debian/ubuntu checks
since modinfo -p doesn't always show the size of the parameter ie uint on operating systems like RHEL6
useless messages being sent to STDOUT
nvme module is determined
…DLINE_LINUX is set in /etc/default/grub and use the appropriate variable
rather than /boot/grub/grub.cfg
… /boot/grub/menu.lst respectively
…ck_cmd's have been defined
…ll fail to load the nvme driver at boot so using nvme.ko is preferred over simply looking for the string 'nvme'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None
Description of changes:
Update the nitro_check_script.sh bash script to include detection and configuration of nvme io_timeout kernel parameters in accordance with https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/nvme-ebs-volumes.html#timeout-nvme-ebs-volumes.
By configuring the check directly into the nitro_check_script.sh script, we can avoid nvme-related IO timeout (input/output) errors in future.
Checks and confirms which module is available with nvme_core taking precendence over nvme. io_timeout values are set according to the maximum supported by the parameter.
Uses tools such as grub2-mkconfig, grub-mkconfig, or grubby according to the operating system to modify kernel parameters.
Backs up any files that are modified ie /etc/default/grub, /boot/grub2/grub.cfg etc as /path/to/file.backup.$time_stamp to allow user to rollback any changes.
Tested against:
Debian 10
Debian 11
Ubuntu 14.04
Ubuntu 16.04
Ubuntu 18.04
Ubuntu 20.04
CentOS 6.10
CentOS 7.9
RHEL 6.10
RHEL 7.7
RHEL 8.2
Oracle Linux 7.5
SLES 12
SLES 15
AL1
AL2
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.