Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scan): add support for specifying the scan function timeout #1340

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

bdmartin
Copy link
Contributor

@bdmartin bdmartin commented Dec 3, 2024

Description

  • Add a property that allows specifying the scan lambda's timeout.
  • The corresponding documentation has also been added.
  • I also upgraded a couple of pre-commit hooks as they were either issuing stark warnings or were plain failing to run.

Fixes #1339

Testing

  • Unit test added.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@bdmartin
Copy link
Contributor Author

bdmartin commented Jan 6, 2025

Hi @dontirun, does this patch look reasonable to you?

Copy link
Contributor

@dontirun dontirun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mergify mergify bot merged commit aaea17d into awslabs:main Jan 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow for specification of the scan lambda timeout
2 participants