Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleanup load balancers in spark operator cleanup #749

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

alanty
Copy link
Contributor

@alanty alanty commented Feb 10, 2025

What does this PR do?

Adds commands to the cleanup.sh script in the spark operator blueprint to ensure the load balancer and related resources created for the Nginx ingress controller are deleted. This avoids problems deleting the VPC, resolving #741

I used the same commands found in the nvidia-triton-server blueprint.

Motivation

cleaning up this blueprint was inconsistent,

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@askulkarni2 askulkarni2 merged commit 0575517 into awslabs:main Feb 10, 2025
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants