Skip to content

Commit

Permalink
Rebase with main
Browse files Browse the repository at this point in the history
  • Loading branch information
enriquh authored and lmouhib committed Apr 5, 2024
1 parent e4638de commit 93f0833
Show file tree
Hide file tree
Showing 3 changed files with 57 additions and 20 deletions.
54 changes: 48 additions & 6 deletions framework/API.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import { Duration, RemovalPolicy } from 'aws-cdk-lib';
export interface QuickSightSubscriptionProps {

/**
* The name of your Amazon QuickSight account.
* This name is unique over all of Amazon Web Services, and it appears only when users sign in.
* The name of your Amazon QuickSight account.
* This name is unique over all of Amazon Web Services, and it appears only when users sign in.
* You can't change AccountName value after the Amazon QuickSight account is created.
*/
readonly accountName: string;
Expand All @@ -27,7 +27,7 @@ export interface QuickSightSubscriptionProps {
* @default - ENTERPRISE is used as default.
*/
readonly edition: QuickSightEdition;

/**
* The Amazon Web Services account ID of the account that you're using to create your Amazon QuickSight account.
*/
Expand Down Expand Up @@ -87,5 +87,5 @@ export enum QuickSightAuthenticationMethod {
}

export enum QuickSightEdition {
ENTERPRISE = 'ENTERPRISE',
ENTERPRISE = 'ENTERPRISE',
}
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0

import { Context, TrackedConstruct, TrackedConstructProps } from "../../../utils";
import { DsfProvider } from '../../../utils/lib/dsf-provider';
import { QuickSightSubscriptionProps, QuickSightAuthenticationMethod } from './quicksight-subscription-props';
import { Construct } from 'constructs';
import { CustomResource, Duration, RemovalPolicy } from 'aws-cdk-lib';
import { IRole, PolicyDocument, Role , ServicePrincipal, PolicyStatement, Effect } from 'aws-cdk-lib/aws-iam';
import { ILogGroup } from 'aws-cdk-lib/aws-logs';
import { IRole, PolicyDocument, Role, ServicePrincipal, PolicyStatement, Effect } from 'aws-cdk-lib/aws-iam';
import { IFunction } from 'aws-cdk-lib/aws-lambda';
import { ILogGroup } from 'aws-cdk-lib/aws-logs';
import { Construct } from 'constructs';
import { QuickSightSubscriptionProps } from './quicksight-subscription-props';
import { QuickSightSubscriptionProps, QuickSightAuthenticationMethod } from './quicksight-subscription-props';
import { Context, TrackedConstruct, TrackedConstructProps } from '../../../utils';
import { DsfProvider } from '../../../utils/lib/dsf-provider';

Expand Down Expand Up @@ -118,7 +113,7 @@ export class QuickSightSubscription extends TrackedConstruct {
this.adminGroup = props.adminGroup;
this.authorGroup = props.authorGroup;
this.readerGroup = props.readerGroup;
this.identityRegion = props.identityRegion;
this.identityRegion = props.identityRegion;

this.policyActions = [
'quicksight:Subscribe',
Expand Down Expand Up @@ -157,7 +152,7 @@ export class QuickSightSubscription extends TrackedConstruct {
}

this.executionRole = new Role(this, 'Role', {
assumedBy: new ServicePrincipal('lambda.amazonaws.com'),
assumedBy: new ServicePrincipal('lambda.amazonaws.com'),
inlinePolicies: {
QuickSightSubscription: new PolicyDocument({
statements: [
Expand Down Expand Up @@ -200,7 +195,7 @@ export class QuickSightSubscription extends TrackedConstruct {
EDITION: props.edition,
IDENTITY_REGION: props.identityRegion,
},
},
},
queryInterval: Duration.seconds(10),
removalPolicy: this.removalPolicy,
});
Expand Down

0 comments on commit 93f0833

Please sign in to comment.