Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump testcontainers from 1.20.2 to 1.20.3 #430

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

agebhar1
Copy link
Contributor

Description

With tc-gh9370 Docker compose initialization is cleared. The shared (static) Docker compose instance is not valid in successive tests anymore.

Fixed it by running Docker compose for each test class.

Test Steps

mvn clean verify -Drevision=$(git describe --tags --always)

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

With [tc-gh9370] Docker compose initialization is cleared. The shared (static)
Docker compose instance is not valid in successive tests anymore.

Fixed it by running Docker compose for each test class.

[tc-gh9370]: testcontainers/testcontainers-java#9370
@agebhar1 agebhar1 requested a review from a team as a code owner October 31, 2024 14:00
@embano1 embano1 enabled auto-merge October 31, 2024 20:30
Copy link
Contributor

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You ROCK!

@embano1 embano1 added this pull request to the merge queue Oct 31, 2024
Merged via the queue into awslabs:main with commit fc9a223 Oct 31, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants