Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Compose updates #465

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Docker Compose updates #465

merged 2 commits into from
Jan 3, 2025

Conversation

embano1
Copy link
Contributor

@embano1 embano1 commented Dec 29, 2024

Description

Updates Docker Compose instructions in CONTRIBUTING and removes version attribute from compose files to avoid warning.

Test Steps

Existing tests pass.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#463

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixes "WARN[0000] /Users/micha/dev/eventbridge-kafka-connector/e2e/docker_compose.yaml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion
"

Signed-off-by: Michael Gasch <[email protected]>
@embano1 embano1 requested a review from a team as a code owner December 29, 2024 21:44
@embano1 embano1 enabled auto-merge December 29, 2024 21:44
@embano1 embano1 linked an issue Dec 30, 2024 that may be closed by this pull request
Copy link
Contributor

@maschnetwork maschnetwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@embano1 embano1 added this pull request to the merge queue Jan 3, 2025
Merged via the queue into awslabs:main with commit e841f81 Jan 3, 2025
10 of 11 checks passed
@embano1 embano1 deleted the issue-463 branch January 3, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING because docker-compose CLI is deprecated
2 participants