Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operationalMetric): Added api service metric #69

Merged
merged 12 commits into from
Oct 31, 2023

Conversation

dineshSajwan
Copy link
Contributor

Fixes #

Added API service metric.

  • AWS_SDK_UA_APP_ID = <Construct_name>+<Stack_ID>
  • Added enableOperationalmetric as user prop to disable API service metric

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@dineshSajwan dineshSajwan changed the title feat (Operational Metric): Added api service metric feat (Construct): Added api service metric Oct 30, 2023
@dineshSajwan dineshSajwan changed the title feat (Construct): Added api service metric feat(operationalMetric): Added api service metric Oct 30, 2023
@krokoko
Copy link
Collaborator

krokoko commented Oct 30, 2023

Could you revert the changes to the python files since it seems nothing was modified ?

@krokoko
Copy link
Collaborator

krokoko commented Oct 30, 2023

Also, what about the lambda layer construct ? Should we add in the python code a helper to set the value of the environmental variable, and user can disable it by calling a method ?

Copy link
Collaborator

@scottschreckengaust scottschreckengaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enableOperationalMetric

src/patterns/gen-ai/aws-qa-appsync-opensearch/index.ts Outdated Show resolved Hide resolved
src/patterns/gen-ai/aws-qa-appsync-opensearch/index.ts Outdated Show resolved Hide resolved
@dineshSajwan dineshSajwan requested a review from hvital October 31, 2023 17:56
hvital
hvital previously approved these changes Oct 31, 2023
@krokoko krokoko merged commit f295ec5 into main Oct 31, 2023
@krokoko krokoko deleted the feature/operational_metric branch October 31, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants