Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add dependency to resource for CRIS #909

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Jan 23, 2025

Fixes #899

Thanks to @mccauleyp for the investigation. Fixes the issue where some CRIS models cannot be used as there is a missing dependency.

Test:

const cris = bedrock.CrossRegionInferenceProfile.fromConfig({
      geoRegion: bedrock.CrossRegionInferenceProfileRegion.US,
      model: bedrock.BedrockFoundationModel.ANTHROPIC_CLAUDE_3_5_SONNET_V2_0,
    });
    
    const agent = new bedrock.Agent(this, 'Agent', {
      foundationModel: cris,
      instruction: 'You are a helpful and friendly agent that answers questions about agriculture.',
    });

(Also tested with ANTHROPIC_CLAUDE_3_5_HAIKU_V1_0 and ANTHROPIC_CLAUDE_3_5_SONNET_V1_0)

Deployment succeeds:

Screenshot 2025-01-23 at 12 34 23 PM

The correct model is used in the console:

Screenshot 2025-01-23 at 12 34 15 PM

The agent is able to perform requests against the model:

Screenshot 2025-01-23 at 12 34 02 PM

The stack is destroyed correctly:

Screenshot 2025-01-23 at 12 39 21 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link
Member

@anitalewis anitalewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

mergify bot commented Jan 24, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #909 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information.)

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@krokoko krokoko merged commit f32b386 into awslabs:main Jan 24, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bedrock: Agents requiring inference profile fail to deploy
4 participants