Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix Edge Feature None block error #1128

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

jalencato
Copy link
Collaborator

@jalencato jalencato commented Jan 6, 2025

Issue #, if available:

Description of changes:

Previously (before adding edge feature in message passing), we do not require any block information, so the code works fine. Now as we require them for edge feats, we need to make a small fix about it. The error is only triggered in large dataset with workers > 24. Already test successfully with amazon-review dataset with this PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jalencato jalencato linked an issue Jan 6, 2025 that may be closed by this pull request
@jalencato jalencato marked this pull request as ready for review January 6, 2025 17:54
@jalencato jalencato added the ready able to trigger the CI label Jan 6, 2025
@jalencato jalencato requested a review from zhjwy9343 January 6, 2025 17:54
@classicsong classicsong added the 0.4 label Jan 6, 2025
Copy link
Contributor

@classicsong classicsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@classicsong classicsong merged commit 31bf21b into awslabs:main Jan 6, 2025
23 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.4 ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Meet an issue when doing Link Prediction Training
2 participants