Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing node.serviceAccount.annotations in values.yaml #217

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

netikras
Copy link
Contributor

@netikras netikras commented Jul 4, 2024

Issue #, if available:
564
Description of changes:
Added a default annotation for the SA.
ref.: #173 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@unexge
Copy link
Contributor

unexge commented Jul 4, 2024

Thanks for the contribution @netikras! Would you mind updating installation instructions as well to mention this parameter needs to be passed if they're using IAM roles for service accounts? It should be something like:

Note

For EKS users, you need to pass your Role ARN here if you're using IAM roles for service accounts:

$ helm upgrade --install aws-mountpoint-s3-csi-driver \
   --namespace kube-system \
   --set node.serviceAccount.annotations."eks\.amazonaws\.com/role-arn"="arn:aws:iam::account:role/csi-driver-role-name" \
   aws-mountpoint-s3-csi-driver/aws-mountpoint-s3-csi-driver 

@dannycjones dannycjones requested a review from unexge July 10, 2024 13:37
unexge
unexge previously approved these changes Jul 10, 2024
Copy link
Contributor

@unexge unexge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @netikras!

Could you please ensure the code block is properly formatted as a code block?
Screenshot 2024-07-10 at 16 51 55

Currently, it's not formatted as a code block and the escapes in the Helm command are filtered out and, Helm command fails to execute if you don't escape it

docs/install.md Show resolved Hide resolved
@unexge unexge merged commit 985562f into awslabs:main Jul 11, 2024
3 of 4 checks passed
@unexge
Copy link
Contributor

unexge commented Jul 11, 2024

Thank you for the contribution again @netikras!

@netikras
Copy link
Contributor Author

@unexge
too many thanks for a contribution this small, if you asked me 😄

@netikras netikras deleted the patch-1 branch July 12, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants