-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing node.serviceAccount.annotations in values.yaml #217
Conversation
Thanks for the contribution @netikras! Would you mind updating installation instructions as well to mention this parameter needs to be passed if they're using IAM roles for service accounts? It should be something like: Note For EKS users, you need to pass your Role ARN here if you're using IAM roles for service accounts: $ helm upgrade --install aws-mountpoint-s3-csi-driver \
--namespace kube-system \
--set node.serviceAccount.annotations."eks\.amazonaws\.com/role-arn"="arn:aws:iam::account:role/csi-driver-role-name" \
aws-mountpoint-s3-csi-driver/aws-mountpoint-s3-csi-driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @netikras!
Could you please ensure the code block is properly formatted as a code block?
Currently, it's not formatted as a code block and the escapes in the Helm command are filtered out and, Helm command fails to execute if you don't escape it
Co-authored-by: Burak <[email protected]>
Thank you for the contribution again @netikras! |
@unexge |
Issue #, if available:
564
Description of changes:
Added a default annotation for the SA.
ref.: #173 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.