Update reftest to always generate a directory at the root of the reference model #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rence model Signed-off-by: Daniel Carl Jones <[email protected]>
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
passaro
approved these changes
Jan 13, 2025
c-hagem
approved these changes
Jan 13, 2025
keremnc
pushed a commit
to keremnc/mountpoint-s3
that referenced
this pull request
Jan 24, 2025
…rence model (awslabs#1219) This change impacts only Mountpoint's reference tests. The current strategy for generating the tree allows for the root to be a file, which is not possible. This leads to us adding special cases to the reftest comparison logic as well as having bizarre test cases which are hard to understand. This change updates the strategy by ensuring that the root is always a directory, and simplifies some of the unused proptest layers. ### Does this change impact existing behavior? No change to existing Mountpoint behavior. This changes the type of trees generated by our reference tests, removing those that are not possible in Mountpoint. ### Does this change need a changelog entry? No. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Daniel Carl Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change impacts only Mountpoint's reference tests.
The current strategy for generating the tree allows for the root to be a file, which is not possible. This leads to us adding special cases to the reftest comparison logic as well as having bizarre test cases which are hard to understand.
This change updates the strategy by ensuring that the root is always a directory, and simplifies some of the unused proptest layers.
Does this change impact existing behavior?
No change to existing Mountpoint behavior. This changes the type of trees generated by our reference tests, removing those that are not possible in Mountpoint.
Does this change need a changelog entry?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).