Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expected bucket owner test for shared XZ cache #1241

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

vladem
Copy link
Contributor

@vladem vladem commented Jan 22, 2025

Add the expected bucket owner test. The test attempts to use a bucket in another AWS account as a cache and verifies that:

  • write to the cache is not done if the expected bucket owner check is enabled
  • write to the cache is done if the check is disabled
  • write to the cache is done if the cache bucket belongs to the expected account

Does this change impact existing behavior?

No.

Does this change need a changelog entry? Does it require a version change?

No.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@vladem vladem had a problem deploying to PR integration tests January 22, 2025 15:49 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests January 22, 2025 15:49 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests January 22, 2025 15:49 — with GitHub Actions Failure
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 15:49 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 15:49 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 15:49 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 15:49 — with GitHub Actions Inactive
@vladem vladem marked this pull request as draft January 22, 2025 16:15
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 22, 2025 16:33 — with GitHub Actions Inactive
@vladem vladem marked this pull request as ready for review January 22, 2025 16:49
Vlad Volodkin added 3 commits January 24, 2025 16:01
Signed-off-by: Vlad Volodkin <[email protected]>
Signed-off-by: Vlad Volodkin <[email protected]>
Signed-off-by: Vlad Volodkin <[email protected]>
@vladem vladem force-pushed the cache-xoz-expected-bucket-owner-test branch from ec7e356 to 605ea45 Compare January 24, 2025 16:02
@vladem vladem temporarily deployed to PR integration tests January 24, 2025 16:03 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 24, 2025 16:03 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 24, 2025 16:03 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 24, 2025 16:03 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 24, 2025 16:03 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 24, 2025 16:03 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests January 24, 2025 16:03 — with GitHub Actions Inactive
@dannycjones dannycjones self-requested a review January 24, 2025 16:25
@dannycjones dannycjones changed the title Add an expected bucket owner test Add expected bucket owner test for shared XZ cache Jan 24, 2025
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vladem vladem added this pull request to the merge queue Jan 24, 2025
Merged via the queue into awslabs:main with commit b545964 Jan 24, 2025
24 checks passed
@vladem vladem deleted the cache-xoz-expected-bucket-owner-test branch January 24, 2025 17:06
keremnc pushed a commit to keremnc/mountpoint-s3 that referenced this pull request Jan 24, 2025
Add the expected bucket owner test. The test attempts to use a bucket in
another AWS account as a cache and verifies that:

- write to the cache is not done if the expected bucket owner check is
enabled
- write to the cache is done if the check is disabled
- write to the cache is done if the cache bucket belongs to the expected
account

### Does this change impact existing behavior?

No.

### Does this change need a changelog entry? Does it require a version
change?

No.

---

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and I agree to the terms of
the [Developer Certificate of Origin
(DCO)](https://developercertificate.org/).

---------

Signed-off-by: Vlad Volodkin <[email protected]>
Co-authored-by: Vlad Volodkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants