Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge file from the negative cache on create #1250

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Purge file from the negative cache on create #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mountpoint-s3/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

* Add support for appending to objects originally uploaded with a CRC64-NVME checksum. ([#1235](https://github.com/awslabs/mountpoint-s3/pull/1235))

### Other Changes
* Fix an issue where file names were not expelled from negative cache.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include a link to this PR, like in the other entries:

Suggested change
* Fix an issue where file names were not expelled from negative cache.
* Fix an issue where file names were not expelled from negative cache. ([#1250](https://github.com/awslabs/mountpoint-s3/pull/1250))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also:

  • why "file names"? Doesn't it apply to directories as well?
  • we should qualify when the issue occurs.


## v1.14.0 (January 10, 2025)

### New features
Expand Down
2 changes: 2 additions & 0 deletions mountpoint-s3/src/superblock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,8 @@ impl Superblock {
let inode = self
.inner
.create_inode_locked(&parent_inode, &mut parent_state, name, kind, state, true)?;
// Expel inode from negative cache, if it is present
self.inner.negative_cache.remove(parent_inode.ino(), name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider updating the cache in create_inode_locked? It would require changes to the update_from_remote code path, but it could be a better trade off.

LookedUp { inode, stat }
};

Expand Down
Loading