Fuser/fork rebase 01 #1273
Closed
Fuser/fork rebase 01 #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the same cache key across multiple jobs can cause issues if we make assumption about it's content (like installing tools if not hit on the cache).
During certain operation, macOS use some helper that send request to the mountpoint with `crtime` set to `0xffff83da4f80`. That value correspond to `-2_082_844_800u64` which is the difference between the date 1904-01-01 and 1970-01-01 because macOS epoch start at 1904 and not 1970. <macfuse/macfuse#1042> Fix awslabs#217
Co-authored-by: Daniel Carl Jones <[email protected]>
Currently the Filesystem trait forces only a single request dispatch loop, with the idea that a filesystem that wants to be concurrent can just spawn its own threads and dispatch operations on them itself. This works, but it's bad for performance, because it forces every request to bounce across threads. Instead, let's make the Filesystem trait use interior mutability. This allows us to spawn multiple dispatch threads that each block on the FUSE device, read a request, and immediately dispatch it without the bounce. Unfortunately there's not a good way for a trait to be variant in mutability, so this is a breaking API change. We'll need to think more carefully about how to upstream this change. Signed-off-by: James Bornholt <[email protected]>
Add `is_forget()` method to `Request`. Signed-off-by: Alessandro Passaro <[email protected]>
Introduce `Session::run_with_callbacks()` to notify callers before and after kernel messages are dispatched. Signed-off-by: Alessandro Passaro <[email protected]>
## Description of change fuser v0.15.0 added support for creating sessions from FUSE fd. I'm working on a PR to add this support to Mountpoint. We still need to open the FUSE device and call `mount` syscall in order to test this new behavior, and all this logic is already exists with `mnt::Mount`. We could just copy the logic from `mnt::Mount` - but since we already have this fork, making this change seemed fine to me. Maybe we can also consider upstreaming it. ## Does this change impact existing behavior? No ## Does this change need a changelog entry in any of the crates? No --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Burak Varli <[email protected]>
Our fuser fork emits a lot of warnings during builds, impacting our pull requests. This change addresses missing documentation on one struct in fuser (which was introduced by our change in awslabs#1098). This change is a good candidate to be contributed to upstream. Once contributed, this commit can be removed. Relevant issues: N/A No. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Daniel Carl Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Remove all TODO messages in desc. For PR description guidance, review https://github.com/awslabs/mountpoint-s3/blob/main/doc/CONTRIBUTING.md#pull-request-title-and-description.
TODO: What changed and why?
Does this change impact existing behavior?
TODO: Please confirm there's no breaking change, or call out any that are made.
Does this change need a changelog entry? Does it require a version change?
TODO: Confirm with justification if not required.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).