Fix intermittent issue with metrics tests #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
force-pushed
the
metrics-tests-failures
branch
from
60782e9 to
5c3ce0e
Compare
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
previously approved these changes
Dec 4, 2023
passaro
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Change looks good to me and it fixes the issue. My only concern is that if we ever decide to start looking at metrics in other tests, we will have to review it again.
On the other hand, if we move this test to the tests folder and run it in isolation, the filter becomes redundant.
mountpoint-s3/src/metrics.rs
Outdated
| const TEST_GAUGE: &str = "test_gauge"; | ||
| const TEST_HISTOGRAM: &str = "test_histogram"; | ||
| const TEST_METRICS: [&str; 3] = [TEST_COUNTER, TEST_GAUGE, TEST_HISTOGRAM]; | ||
|
|
||
| #[test] | ||
| fn basic_metrics() { | ||
| let sink = Arc::new(MetricsSink::new()); | ||
| let recorder = MetricsRecorder { sink: sink.clone() }; | ||
| metrics::set_boxed_recorder(Box::new(recorder)).unwrap(); |
There was a problem hiding this comment.
I think the issue is actually with set_boxed_recorder: this is global and supposed to be only called once. At the moment, this is indeed the only test that calls it, but as you noticed, other tests run in parallel may interfere with this one.
Should we move this test to the "integration tests", where it can be run in isolation?
There was a problem hiding this comment.
Daniel suggested using rusty_fork_test which makes this test to run in a separate process preventing any global state from interfering with it.
There was a problem hiding this comment.
Yes, that works too. And it's probably better than my suggestion: no need to expose e.g. MetricsSink.
arsh
force-pushed
the
metrics-tests-failures
branch
from
5c3ce0e to
572b89b
Compare
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
Signed-off-by: Andres Santana <[email protected]>
arsh
force-pushed
the
metrics-tests-failures
branch
from
572b89b to
2bfa549
Compare
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes intermittent issues when testing metrics emission by using
rusty_fork_testto make sure there isn't any global state interfering with this test.Relevant issues: N/A
Does this change impact existing behavior?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).