Print successful mount for both foreground and background modes. Also update documentation for the --no-log argument.
#668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
passaro
reviewed
Dec 5, 2023
arsh
force-pushed
the
update-no-log-doc
branch
from
cd4ed10 to
c233d38
Compare
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
arsh
changed the title
--no-log argument.--no-log argument.
Also, update documentation for the `--no-log` argument. Signed-off-by: Andres Santana <[email protected]>
arsh
force-pushed
the
update-no-log-doc
branch
from
c233d38 to
f039a91
Compare
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
arsh
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
|
This seems fine. Though I kind of liked the idea of |
jamesbornholt
approved these changes
Dec 8, 2023
passaro
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Print successful mount for both foreground and background modes. Also update documentation for the
--no-logargument.Relevant issues: N/A
Does this change impact existing behavior?
Yes. When running on foreground mode, we print a message to stdout after a successful mount. As noted in the documentation, the
--no-logargument has no effects on this or any messages sent to stdout.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).