Feature/handle pytorch load changes #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 4, 2025 14:02
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Error
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Failure
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Failure
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
had a problem deploying
to
integration-tests
GitHub Actions
Failure
muddyfish
approved these changes
Feb 4, 2025
| text, | ||
| ) | ||
|
|
||
| scalars = ( | ||
| none() | ||
| | booleans() | ||
| booleans() |
There was a problem hiding this comment.
Depending on what we care about for 'python primitives' this is not a complete list :)
There was a problem hiding this comment.
I agree, that it is primitives that now supported by torch.load
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
IsaevIlya
temporarily deployed
to
integration-tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PyTorch 2.6,
torch.load()now requires explicitweights_onlyparameter. When defaulting toTrue,it restricts supported data types during loading (see serialization docs).
Set
weights_only=FalseinS3LightningCheckpointto match PyTorch Lightning'sCheckpointIOimplementation, maintain backwards compatibility.By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.