Causal replay #156
Merged
Causal replay #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aurel300
force-pushed
the
feature/causal-replay
branch
from
118759d to
f6ba23b
Compare
jorajeev
reviewed
Aug 13, 2024
Aurel300
force-pushed
the
feature/causal-replay
branch
from
f6ba23b to
a63bbdf
Compare
jorajeev
reviewed
Aug 14, 2024
| }) | ||
| .expect_err("test should panic"); | ||
| let output = result.downcast::<&str>().unwrap(); | ||
| assert_eq!(*output, "expected panic"); |
There was a problem hiding this comment.
Could you also add an assert about steps_skipped to test that functionality too?
There was a problem hiding this comment.
I'm not sure how to do this (easily): Runner::new takes the scheduler we construct, so there is no access to it afterwards.
There was a problem hiding this comment.
Okay for now. Maybe we can find a way to get additional metrics through the metrics scheduler
| }) | ||
| .expect_err("test should panic"); | ||
| let output = result.downcast::<&str>().unwrap(); | ||
| assert_eq!(*output, "expected panic"); |
There was a problem hiding this comment.
Similar comments here: add assertions for me() and steps_skipped
Aurel300
force-pushed
the
feature/causal-replay
branch
from
a63bbdf to
83cdcef
Compare
jorajeev
previously approved these changes
Aug 14, 2024
auto-merge was automatically disabled
August 14, 2024 22:04
Head branch was pushed to by a user without write access
Aurel300
force-pushed
the
feature/causal-replay
branch
from
83cdcef to
188de43
Compare
jorajeev
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to add causal dependency to the replay scheduler. To use this,
set_target_clockshould be invoked on aReplaySchedulerinstance with the clock of the failure event (provided as a slice of integers). Some things to resolve still:Tasks rather than justTaskIds. I think we discussed that schedulers should generally have access to more information about tasks, so if this is the approach we take, theTaskinterface might deserve some more cleanup. Even more so if schedulers are eventually intended to be defined in a separate crate.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.