Fix: remove failed queue attributes from cache #1491
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1239
📢 Type of change
📜 Description
Addresses the issue where failed
CompletableFuture<QueueAttributes>objects were cached indefinitely, causing all subsequent requests to fail until service restart.Problem
When queue creation hasn't propagated to AWS SQS (eventual consistency), the initial failure gets cached permanently. This requires service restart to retry, as reported in #1234:
Solution
Implemented Option A (Minimal Change) as discussed - automatically remove failed futures from cache:
Key Benefits:
💚 How did you test it?
Added 4 comprehensive tests:
shouldRemoveFailedQueueAttributesFromCache- Verifies failed cache removal and retryshouldCacheSuccessfulQueueAttributes- Verifies successful cache behaviorshouldCacheSuccessfulQueueAttributesWithAttributeNames- Verifies cache with config optionsshouldCreateSeparateObservationsForRetryAfterCacheFailure- Verifies observability tracking📝 Checklist
🔮 Next steps
Potential improvements for follow-up PRs:
SqsMessageListenerContainer