Introduce loading parameters as key value store #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatejNedic
requested review from
maciejwalkowiak and
tomazfernandes
as code owners
github-actions
bot
added
component: parameter-store
|
|
||
| [source,properties] | ||
| ---- | ||
| spring.cloud.aws.region=eu-central-1 |
There was a problem hiding this comment.
Maybe we can use different example properties to not confuse readers that it has something to do with Spring Cloud AWS region and endpoint configuration?
| private static Log LOG = LogFactory.getLog(ParameterStorePropertySource.class); | ||
| private static final String PREFIX_PART = "?prefix="; | ||
|
|
||
| private static final String PREFIX_PROPERTIES_LOAD = "?properties"; |
There was a problem hiding this comment.
is that a notation you came up with or other Spring projects follow it too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Since Parameter Store supports 4kb sometimes i want to have whole ConfigurationProperty class located in one parameter. Currently this was not possible
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps